chore: upgrade assets-controllers v62 #32546
+62
−62
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4892,6 +4892,52 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@metamask-previews/assets-controllers@npm:61.0.0-preview-ace5334a": | ||
| version: 61.0.0-preview-ace5334a | ||
| resolution: "@metamask-previews/assets-controllers@npm:61.0.0-preview-ace5334a" | ||
| dependencies: | ||
| "@ethereumjs/util": "npm:^9.1.0" | ||
| "@ethersproject/abi": "npm:^5.7.0" | ||
| "@ethersproject/address": "npm:^5.7.0" | ||
| "@ethersproject/bignumber": "npm:^5.7.0" | ||
| "@ethersproject/contracts": "npm:^5.7.0" | ||
| "@ethersproject/providers": "npm:^5.7.0" | ||
| "@metamask/abi-utils": "npm:^2.0.3" | ||
| "@metamask/base-controller": "npm:^8.0.1" | ||
| "@metamask/contract-metadata": "npm:^2.4.0" | ||
| "@metamask/controller-utils": "npm:^11.7.0" | ||
| "@metamask/eth-query": "npm:^4.0.0" | ||
| "@metamask/keyring-api": "npm:^17.4.0" | ||
| "@metamask/metamask-eth-abis": "npm:^3.1.1" | ||
| "@metamask/polling-controller": "npm:^13.0.0" | ||
| "@metamask/rpc-errors": "npm:^7.0.2" | ||
| "@metamask/snaps-utils": "npm:^9.2.0" | ||
| "@metamask/utils": "npm:^11.2.0" | ||
| "@types/bn.js": "npm:^5.1.5" | ||
| "@types/uuid": "npm:^8.3.0" | ||
| async-mutex: "npm:^0.5.0" | ||
| bitcoin-address-validation: "npm:^2.2.3" | ||
| bn.js: "npm:^5.2.1" | ||
| immer: "npm:^9.0.6" | ||
| lodash: "npm:^4.17.21" | ||
| multiformats: "npm:^13.1.0" | ||
| single-call-balance-checker-abi: "npm:^1.0.0" | ||
| uuid: "npm:^8.3.2" | ||
| peerDependencies: | ||
| "@metamask/accounts-controller": ^28.0.0 | ||
| "@metamask/approval-controller": ^7.0.0 | ||
| "@metamask/keyring-controller": ^21.0.0 | ||
| "@metamask/network-controller": ^23.0.0 | ||
| "@metamask/permission-controller": ^11.0.0 | ||
| "@metamask/preferences-controller": ^17.0.0 | ||
| "@metamask/providers": ^21.0.0 | ||
| "@metamask/snaps-controllers": ^11.0.0 | ||
| "@metamask/transaction-controller": ^55.0.0 | ||
| webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0 | ||
| checksum: 10/c26d3a52a0c9e0d70fd3ddd0eb914b2fc19b702cacab5887f8a4f89683dae01535b02b5f8b9fffa65c97a363956f080e5b5dd32d046c9b3582ecd7d9eb5ce18b | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@metamask/abi-utils@npm:^2.0.2, @metamask/abi-utils@npm:^2.0.3, @metamask/abi-utils@npm:^2.0.4": | ||
| version: 2.0.4 | ||
| resolution: "@metamask/abi-utils@npm:2.0.4" | ||
|
|
@@ -4992,55 +5038,9 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@metamask/assets-controllers@patch:@metamask-previews/[email protected]#.yarn/patches/@metamask-assets-controllers-npm-60.0.0-7fc404c3fc.patch::locator=metamask-crx%40workspace%3A.": | ||
| version: 61.0.0-preview-ace5334a | ||
| resolution: "@metamask/assets-controllers@patch:@metamask-previews/assets-controllers@npm%3A61.0.0-preview-ace5334a#.yarn/patches/@metamask-assets-controllers-npm-60.0.0-7fc404c3fc.patch::version=61.0.0-preview-ace5334a&hash=f9ee52&locator=metamask-crx%40workspace%3A." | ||
| dependencies: | ||
| "@ethereumjs/util": "npm:^9.1.0" | ||
| "@ethersproject/abi": "npm:^5.7.0" | ||
|
|
@@ -5049,7 +5049,7 @@ __metadata: | |
| "@ethersproject/contracts": "npm:^5.7.0" | ||
| "@ethersproject/providers": "npm:^5.7.0" | ||
| "@metamask/abi-utils": "npm:^2.0.3" | ||
| "@metamask/base-controller": "npm:^8.0.1" | ||
| "@metamask/contract-metadata": "npm:^2.4.0" | ||
| "@metamask/controller-utils": "npm:^11.7.0" | ||
| "@metamask/eth-query": "npm:^4.0.0" | ||
|
|
@@ -5070,17 +5070,17 @@ __metadata: | |
| single-call-balance-checker-abi: "npm:^1.0.0" | ||
| uuid: "npm:^8.3.2" | ||
| peerDependencies: | ||
| "@metamask/accounts-controller": ^28.0.0 | ||
| "@metamask/approval-controller": ^7.0.0 | ||
| "@metamask/keyring-controller": ^21.0.0 | ||
| "@metamask/network-controller": ^23.0.0 | ||
| "@metamask/permission-controller": ^11.0.0 | ||
| "@metamask/preferences-controller": ^17.0.0 | ||
| "@metamask/providers": ^21.0.0 | ||
| "@metamask/snaps-controllers": ^11.0.0 | ||
| "@metamask/transaction-controller": ^55.0.0 | ||
| webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0 | ||
| checksum: 10/1d99c36dae2f1f57bfa9b7266f1932dd9997433d2c3336dde4736f79c3ca765e669bcf60991f442bbcdb09d92a3d2970a355a2560cde9d33b2eb5eabb1f7aace | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
|
|
@@ -30013,7 +30013,7 @@ __metadata: | |
| "@metamask/announcement-controller": "npm:^7.0.3" | ||
| "@metamask/api-specs": "npm:^0.13.0" | ||
| "@metamask/approval-controller": "npm:^7.0.0" | ||
| "@metamask/assets-controllers": "patch:@metamask-previews/assets-controllers@61.0.0-preview-ace5334a#.yarn/patches/@metamask-assets-controllers-npm-60.0.0-7fc404c3fc.patch" | ||
| "@metamask/auto-changelog": "npm:^2.1.0" | ||
| "@metamask/base-controller": "npm:^8.0.0" | ||
| "@metamask/bitcoin-wallet-snap": "npm:^0.9.0" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccharly do you this this call is still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's time we get rid of those now (even the transaction force-fetch down below).
Most of the controllers now either reacts to
:accountAddedor to:account{AssetList,Transactions,Balances}Updated, so they would get those info "asynchronously".Also, our preinstalled Snaps follow a different architecture now and they normally just fetch the balances/assets/transactions using a cron, so they might not have those info right away (unless they are force-fetching and blocking until they get the results in
getAccountBalancesandgetTransactions...).IMO, as long as we show a spinner on the balances until we get the Snap event
:accountBalancesUpdated, we should be ok to remove those calls.