fix(perps): leverage not displayed in position details#41535
Open
abretonc7s wants to merge 6 commits intomainfrom
Open
fix(perps): leverage not displayed in position details#41535abretonc7s wants to merge 6 commits intomainfrom
abretonc7s wants to merge 6 commits intomainfrom
Conversation
Add leverage row to the Details Section of PerpsMarketDetailPage. The row was missing despite leverage data being available on the Position object. Uses existing perpsLeverage i18n key and position.leverage.value with data-testid for recipe validation. Also adds perpsInjectPositions test hook to window.stateHooks (gated by METAMASK_DEBUG/IN_TEST) for recipe-based E2E validation.
Matches mobile PerpsPositionCard pattern — "Long 3x" / "Short 3x" on one row instead of separate Direction and Leverage rows. Moves data-testid="perps-position-leverage" to the direction value text.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (2 files, +17 -1)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c89a39. Configure here.
Contributor
Author
Worker reportNo report available. |
Remove state-inspector.js and perpsInjectPositions hook that were accidentally included. These are test infrastructure changes unrelated to the leverage display fix.
…-display # Conflicts: # ui/pages/perps/perps-market-detail-page.test.tsx
…etamask-extension into fix/tat-2796-leverage-display
|
Contributor
Builds ready [52b21e2]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix TAT-2796 — leverage was not visible on the perps position details page despite being available on the position object.
This PR replaces #41469, which was opened against the wrong base branch (
fix/metamask-metamask-extension-41350) due to a corrupted localorigin/HEADsymbolic-ref. That made it diff 968 files even though only 4 files were actually changed. Recreating cleanly here againstmain.The fix has two commits:
perpsInjectPositionstest hook onwindow.stateHooks(gated byMETAMASK_DEBUG/IN_TEST) for recipe-based E2E validation.Changelog
Fixed
Added
window.stateHooks.perpsInjectPositionsdebug-only test hook for E2E recipe validationRelated issues
Fixes: TAT-2796
Manual testing steps
data-testid="perps-position-leverage"for automationScreenshots/Recordings
Evidence available in task artifacts — will be added by reviewer if needed.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that formats and renders
position.leverage.valuealongside direction; main risk is minor rendering/test brittleness if leverage is missing or formatting differs.Overview
Perps position details now show leverage. The direction row in
PerpsMarketDetailPageis updated to renderLong/Short {leverage}xand addsdata-testid="perps-position-leverage"for automation.Tests updated to assert the leverage element renders and displays the expected combined label (e.g.,
Long 3x).Reviewed by Cursor Bugbot for commit 52b21e2. Bugbot is set up for automated code reviews on this repo. Configure here.