Skip to content

fix(perps): leverage not displayed in position details #41535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abretonc7s wants to merge 7 commits into
base: main
Choose a base branch
from
+17 −1
Open

fix(perps): leverage not displayed in position details #41535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
803398a
fix: display leverage in perps position details
abretonc7s Apr 3, 2026
2c89a39
fix(perps): combine direction and leverage into single row
abretonc7s Apr 3, 2026
5854d4a
fix: address review comments on PR #41535
abretonc7s Apr 10, 2026
b3f7c6e
fix: remove unrelated files from leverage display PR
abretonc7s Apr 10, 2026
dd0a8a8
Merge remote-tracking branch 'origin/main' into fix/tat-2796-leverage…
abretonc7s Apr 10, 2026
52b21e2
Merge branch 'fix/tat-2796-leverage-display' of github.com:MetaMask/m…
abretonc7s Apr 10, 2026
0765400
fix: add unicode flag to RegExp in leverage display test
abretonc7s Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ui/pages/perps/perps-market-detail-page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,20 @@ describe('PerpsMarketDetailPage', () => {
).toBeGreaterThanOrEqual(1);
});

it('displays leverage value in position details', () => {
const store = mockStore(createMockState(true));

const { getByTestId, getByText } = renderWithProvider(
<PerpsMarketDetailPage />,
store,
);

expect(getByTestId('perps-position-leverage')).toBeInTheDocument();
expect(
getByText(new RegExp(`${messages.perpsLong.message} 3x`, 'u')),
).toBeInTheDocument();
});

it('displays stats section', async () => {
const store = mockStore(createMockState(true));

Expand Down
4 changes: 3 additions & 1 deletion ui/pages/perps/perps-market-detail-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,12 @@ const PerpsMarketDetailPage: React.FC = () => {
? TextColor.SuccessDefault
: TextColor.ErrorDefault
}
data-testid="perps-position-leverage"
>
{parseFloat(position.size) >= 0
? t('perpsLong')
: t('perpsShort')}
: t('perpsShort')}{' '}
{position.leverage.value}x
</Text>
</Box>

Expand Down
Loading