-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: align sdk connection ui with latest permissions system #14605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
- Removed unused imports and consolidated necessary ones for better readability. - Refactored the `hideSheet` and `handleConfirm` functions to use `useCallback` for performance optimization. - Simplified the rendering logic in `renderConnectScreens` by removing unnecessary conditions. - Enhanced overall code structure for improved maintainability.
|
Updated the hostname extraction logic in the PermissionsSummary component to gracefully handle invalid URLs by returning the original string or an empty string. This prevents potential errors when processing URLs. Additionally, removed outdated tests related to SDK URL status from AccountConnect.test.tsx to streamline the test suite.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14605 +/- ##
==========================================
- Coverage 67.52% 67.49% -0.04%
==========================================
Files 2307 2307
Lines 49589 49573 -16
Branches 7189 7183 -6
==========================================
- Hits 33487 33459 -28
- Misses 13983 14003 +20
+ Partials 2119 2111 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
This PR updates the SDK connection flow to consistently use the latest permissions system UI, removing legacy components and streamlining the connection experience.
AccountConnectSingle
component in favor of using the newerPermissionsSummary
component consistentlyisSdkUrlUnknown
useCallback
handleConfirm
functionRelated issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist