-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore(deps): bump @metamask/message-signing-snap to v1.1.2 #15141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
V00D00-child
wants to merge
1
commit into
main
Choose a base branch
from
bump-message-signing-snap-to-v1.1.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mirceanis
approved these changes
May 6, 2025
28d85b7
to
899d1ad
Compare
899d1ad
to
dc71b55
Compare
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 6, 2025
## **Description** This is a version bump for the preinstalled @metamask/message-signing-snap to v1.1.2 This latest version updates the `message signing snap` `endowment:rpc` to allow requests from a Snap and adds [npm:@metamask/gator-permissions-snap](https://www.npmjs.com/package/@metamask/gator-permissions-snap/v/0.2.1) to `initialConnections`. [](https://codespaces.new/MetaMask/metamask-extension/pull/32521?quickstart=1) ## **Related issues** relates to: MetaMask/message-signing-snap#128 required by: MetaMask/snap-7715-permissions#84 relates to: MetaMask/metamask-mobile#15141 ## **Manual testing steps** No user-facing changes ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
dc71b55
to
641c019
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
No E2E Smoke Needed
If the PR does not need E2E smoke test run
No QA Needed
Apply this label when your PR does not need any QA effort.
no-changelog
Indicates no external facing user changes, therefore no changelog documentation needed
release-7.46.0
Issue or pull request that will be included in release 7.46.0
team-readable-permissions
MetaMask Readable Permissions Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a version bump for the preinstalled @metamask/message-signing-snap to v1.1.2
This latest version updates the
message signing snap
endowment:rpc
to allow requests from a Snap and adds npm:@metamask/gator-permissions-snap toinitialConnections
.Related issues
relates to: MetaMask/message-signing-snap#128
required by: https://github.com/MetaMask/snap-7715-permissions/pull/84
relates to: MetaMask/metamask-extension#32521
Manual testing steps
There are no user-facing changes to test
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist