Persisting Granted Permissions with MM Profile Sync #84

V00D00-child · 2025-04-23T20:58:59Z

What

The @metamask/gator-permissions-snap will automatically store granted permissions using MetaMask Profile Sync.

How

Added the profile sync module
Replace yarn install startup up yarn prepare:snap script
Handle installing @metamask/message-signing-snap for local dev
Add feature flag so storing permissions only happens when running snap locally
Add docs for profile sync integration
Profile sync module public interface

type ProfileSyncManager = {
  getAllGrantedPermissions: () => Promise<PermissionResponse[]>;
  getGrantedPermission: (
    permissionContext: Hex,
  ) => Promise<PermissionResponse | null>;
  storeGrantedPermission: (
    permissionResponse: PermissionResponse,
  ) => Promise<void>;
  storeGrantedPermissionBatch: (
    permissionResponses: PermissionResponse[],
  ) => Promise<void>;
};

Changes local snap server ports:
- @metamask/message-signing-snap: local:http://localhost:8080
- @metamask/permissions-kernel-snap: local:http://localhost:8081
- @metamask/gator-permissions-snap: local:http://localhost:8082

Profile Sync SDK: OAuth 2.0 Authentication flow

See docs for more context, TL;DR

IdentifierID: We will use the SRP identifier that uses the message signing snap to derive a public key.
Identifier Secret: We will derive the private key from the automatic message signing snap using SRP as the identifier. The private key is used to sign an authentication message to allow the user to prove ownership of the SRP identifier.

Granted permissions store flow

See docs for more context, TL;DR

feature: Is the namespace for grouping related object keys. We will reserve a namespace of gator_7715_permissions as the feature name to store all of the user's granted permissions.
object key: This serves as a distinctive identifier for accessing or modifying the granted permission value. We will use the permissionContext (i.e., the encoded signed delegation) as the unique identifier for each item stored under the gator_7715_permissions feature name.
object value: The actual granted permission data stored as a serialized JSON string that should not exceed 400KB.

Granted permissions retrieval flow(view)

See docs for more context, TL;DR

The user can view the granted permission fetched from profile sync on the @metamask/gator-permissions-snap homepage.

Testing e2e locally

Uninstall the previous version of the kernel and gator snap since they are being served from a different port now
Update ./packages/site/.env.development

GATSBY_KERNEL_SNAP_ORIGIN=local:http://localhost:8081
GATSBY_GATOR_SNAP_ORIGIN=local:http://localhost:8082

Follow the steps to set up

# Install dependencies and sets up submodule 
yarn prepare:snap

# Starts local @metamask/message-signing-snap
yarn start:message-signing-snap

# Starts local @metamask/permissions-kernel-snap and @metamask/gator-permissions-snap
yarn start

Send a permission request to snap
Grant the permission
Visit @metamask/gator-permissions-snap homepage and you should see the granted permission details

Task

…uth flow

socket-security · 2025-05-06T21:02:48Z

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. Learn more about Socket for GitHub.

Action	Severity	Alert (click for details)
Block		`@ethersproject/[email protected]` has Network access. Module: net Location: Package overview From: `?` → `npm/[email protected]` → `npm/@ethersproject/[email protected]` ℹ Read more on: This package \| This alert \| What is network access? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@ethersproject/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`@ethersproject/[email protected]` has Network access. Location: Package overview From: `?` → `npm/[email protected]` → `npm/@ethersproject/[email protected]` ℹ Read more on: This package \| This alert \| What is network access? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@ethersproject/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`@metamask/[email protected]` has Network access. Module: globalThis["fetch"] Location: Package overview From: `?` → `npm/@metamask/[email protected]` → `npm/@metamask/[email protected]` ℹ Read more on: This package \| This alert \| What is network access? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@metamask/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`@metamask/[email protected]` has Network access. Module: globalThis["fetch"] Location: Package overview From: packages/permissions-provider-snap/package.json → `npm/@metamask/[email protected]` ℹ Read more on: This package \| This alert \| What is network access? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@metamask/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has Network access. Module: globalThis["fetch"] Location: Package overview From: packages/permissions-provider-snap/package.json → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is network access? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has Native code. Location: Package overview From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| Why is native code a concern? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has Native code. Location: Package overview From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| Why is native code a concern? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: junderw Previous Author: dcousens From: `?` → `npm/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: dcousens Previous Author: jprichardson From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: ralxz Previous Author: holgerd77 From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: ralxz Previous Author: holgerd77 From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: perrymitchell Previous Author: alizain From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		`[email protected]` is Deprecated. Reason: New package name format for new versions: @ethereumjs/wallet. Please update. From: `?` → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is a deprecated package? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

## **Description** This is a version bump for the preinstalled @metamask/message-signing-snap to v1.1.2 This latest version updates the `message signing snap` `endowment:rpc` to allow requests from a Snap and adds [npm:@metamask/gator-permissions-snap](https://www.npmjs.com/package/@metamask/gator-permissions-snap/v/0.2.1) to `initialConnections`. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32521?quickstart=1) ## **Related issues** relates to: MetaMask/message-signing-snap#128 required by: MetaMask/snap-7715-permissions#84 relates to: MetaMask/metamask-mobile#15141 ## **Manual testing steps** No user-facing changes ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…p locally

jeffsmale90

Looking good - I sure hope that we can improve the developer experience around the message signing snap though!

Maybe only configuring the message signing snap in local if an environment var STORE_DELEGATIONS is set or something so that we only need to set it up if we are testing something related to storage would be a worthwhile change in the short term.

scripts/prepare-snap.sh

packages/permissions-provider-snap/docs/usingMessageSigningSnap.md

packages/permissions-provider-snap/package.json

packages/permissions-provider-snap/src/homepage/index.tsx

packages/permissions-provider-snap/src/profileSync/profileSync.ts

packages/permissions-provider-snap/src/rpc/rpcHandler.ts

packages/permissions-provider-snap/src/profileSync/profileSync.ts

jeffsmale90 · 2025-05-13T23:01:01Z

The default ports in /packages/site/src/config/snap.ts need updating

socket-security · 2025-05-14T17:15:08Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/profile-sync-controller@12.0.0
	ethers@5.8.0

View full report

packages/permissions-provider-snap/src/profileSync/profileSync.ts

…ature name, do not call getUserProfile

packages/permissions-provider-snap/src/profileSync/profileSync.ts

## **Description** This is a version bump for the preinstalled @metamask/message-signing-snap to v1.1.2 This latest version updates the `message signing snap` `endowment:rpc` to allow requests from a Snap and adds [npm:@metamask/gator-permissions-snap](https://www.npmjs.com/package/@metamask/gator-permissions-snap/v/0.2.1) to `initialConnections`. ## **Related issues** relates to: MetaMask/message-signing-snap#128 required by: MetaMask/snap-7715-permissions#84 relates to: MetaMask/metamask-extension#32521 ## **Manual testing steps** There are no user-facing changes to test ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/34373?quickstart=1) Submit transactions to revoke gator permissions. Support single and batch revokes. ## **Changelog**  CHANGELOG entry: Adds a button for the user to revoke a gator permission. ## **Related issues** requires: #33996 requires: MetaMask/core#6033 requires: MetaMask/snap-7715-permissions#108 relates to: MetaMask/snap-7715-permissions#84 ## **Manual testing steps** 1. Generate a MM Flask build - `yarn dist --build-type flask --apply-lavamoat false` 2. Install the latest development version of `@metamask/permissions-kernel-snap` and `@metamask/gator-permissions-snap`. 3. Make a permission 7715 request to store a permission in profile sync. 4. Go to the "All Permissions page". 5. Click revoke to trigger a transaction to revoke a permission. 6. Sign the transaction. - Evidence of revoke permission transaction on testnet: https://sepolia.etherscan.io/tx/0x157ae09d68e0b922876f131648657fd780194625ff2d3825021a8293f6f16dd5 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## Explanation  ### @metamask/gator-permissions-controller #### Current State and Why Change is Needed MetaMask clients currently lack a dedicated system for managing gator permissions that are stored to profile sync via the `@metamask/gator-permissions-snap`. #### Solution and How It Works This change introduces a new `@metamask/gator-permissions-controller` package that provides a comprehensive solution for managing gator permissions in MetaMask clients with gator-snap integration. #### Changes That Might Not Be Obvious - Serialization Strategy: The controller `state` uses JSON serialization for storing permission data fetched from `@metamask/gator-permissions-snap`, which allows for efficient storage and retrieval while maintaining data integrity. The deserialize permission data is represented as a list of gator permissions filtered by permission type and chainId. - Default Permission Structure: The controller initializes with an empty structure for all three permission types, ensuring consistent state even when no permissions are configured #### Package Dependencies and Integration The new package depends on `@metamask/snaps-controllers` as a peer dependency, ensuring it can leverage sending RPC requests to an installed Metamask Snap. This integration allows the `GatorPermissionsController` to forward requests to `@metamask/gator-permissions-snap` to fetch users' Gator permissions that have been stored in the MetaMask Profile Sync service. The `@metamask/gator-permissions-snap` will take on the responsibility of authenticating with MetaMask Profile Sync service using an`SRP` identifier via integration with `@metamask/message-signing-snap`. #### No Dependency Upgrades Required This is a new package that introduces new functionality without requiring changes to existing dependencies. The package uses the current stable versions of `@metamask/base-controller`, `@metamask/utils `,`@metamask/snaps-sdk`, and `@metamask/snaps-utils` following the established patterns in the MetaMask codebase. ## References  Related to(MM snap-7715-permissions): [Persisting Granted Permissions with MM Profile Sync](MetaMask/snap-7715-permissions#84) Requires(MM snap-7715-permissions):[Add new permissionsProvider_getGrantedPermissions RPC](MetaMask/snap-7715-permissions#108) Required by(MM Extension): MetaMask/metamask-extension#33996 ### Gator Permissions Data Flow ```mermaid graph TD %% dApp flow for storing permissions A[dApp client side RPC] -->|RPC| GPS[gator-permissions-snap] C -->|WRITE| D[(permissions stored across all sites)] %% User flow for reading permissions E[user permissions page] -->|UI| F[MM client] F -->|submitRequestToBackground| G[GatorPermissionsController] G --> MSYS[messagingSystem] MSYS -->|handleRequest| SC[SnapController] SC -->|RPC| GPS C -->|READ| D %% SRP Auth GPS -->|OAuth 2.0 Auth| MS[message-signing-snap] MS -->|SRP identifier & signature| C[profile sync service] %% Styling classDef dappStyle fill:#e1f5fe,stroke:#01579b,stroke-width:2px classDef userStyle fill:#f3e5f5,stroke:#4a148c,stroke-width:2px classDef serviceStyle fill:#e8f5e8,stroke:#1b5e20,stroke-width:2px classDef dataStyle fill:#fff3e0,stroke:#e65100,stroke-width:2px classDef authStyle fill:#ffebee,stroke:#c62828,stroke-width:2px classDef systemStyle fill:#fce4ec,stroke:#ad1457,stroke-width:2px class A dappStyle class E,F userStyle class GPS,C serviceStyle class D dataStyle class MS authStyle class G,MSYS,SC systemStyle ``` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

## **Description** Add a new build feature flag `GATOR_PERMISSIONS_ENABLED` that defaults to false. It is intended to serve as a feature flag for the development of the gator-permission page. - When `GATOR_PERMISSIONS_ENABLED=true`, the `/permissions` path will route to the `GatorPermissionsPage` component. - When `GATOR_PERMISSIONS_ENABLED=false` or empty, the `/permissions` path will continue to route to the `PermissionsPage` component. ## **Changelog** CHANGELOG entry: This PR is not End-User-Facing, and it is intended to serve as a feature flag for the development of the gator-permission page. ## **Related issues** relates to: MetaMask/core#6033 required by: #35219 relates to: MetaMask/snap-7715-permissions#84 ## **Manual testing steps** 1. Set `GATOR_PERMISSIONS_ENABLED=true` in `.metamaskrc` 2. Build Flask: `yarn dist --build-type flask --apply-lavamoat false ` 3. Navigate to the `All Permissions page` 4. A Blank page will show as a placeholder to the Gator permission management UI(ie, permission revocation flow). ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This PR lays the foundation for the gator permissions revocation feature. Introduces the following: - The usage of the `GatorPemissionsController` to fetch gator permissions that have been granted to sites. - A dedicated selector that filters `GatorPemissionsController` state to provide necessary data allowing components to render gator permissions revocation features. - Introduces the `GATOR_PERMISSIONS_REVOCATION_ENABLED` feature flag that is set to `false`. This flag is used to continue building the gator permissions view without impacting end-users. - All UI changes are behind the `GATOR_PERMISSIONS_REVOCATION_ENABLED` feature flag. - Dynamic routing based on `GATOR_PERMISSIONS_REVOCATION_ENABLED` feature flag. - 'All permissions' click on the global menu. - 'Back button' click on the site connection page. - Targeting flask build - Once the feature is complete, it will target a MM Flash realease - Placeholder for gator `TokenTransferPage` to be implemented fully #36207 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/35219?quickstart=1) ## **Related issues** requires: MetaMask/core#6033 requires: #35627 requires: MetaMask/snap-7715-permissions#108 requires: #35307 relates to: MetaMask/snap-7715-permissions#84 required by: #36207 ## **Manual testing steps** ### Setting up required MM snaps(Installing snaps): Local version of kernel-snap, gator-snap, and the message-signing-snap from [snap-7715-permissions mono repo](https://github.com/MetaMask/snap-7715-permissions) is required to be running locally to fully test e2e manually. Follow the steps in the README.md to get those snaps up and running. The development site at `http://localhost:8000/` will be used to install the snaps and grant some gator permissions. - repo: [snap-7715-permissions mono repo](https://github.com/MetaMask/snap-7715-permissions) - branch: `dev` - commit hash: `520fffde76c98701e9bac9eb080695e673b7736e` ### Testing e2e flow 1. Ensure `snap-7715-permissions mono` development server is up and running 2. In MM extension `.metamaskrc` file, ensure the following env values are set: ```bash GATOR_PERMISSIONS_ENABLED=true GATOR_PERMISSIONS_REVOCATION_ENABLED=true PERMISSIONS_KERNEL_SNAP_ID='local:http://localhost:8081' GATOR_PERMISSIONS_PROVIDER_SNAP_ID='local:http://localhost:8082' ``` 4. Run `yarn start:flask` 5. Once MM extension is installed, navigate to the snaps development site at `http://localhost:8000/` - Install kernel-snap - Install gator-snap 6. Go to "All Permissions Page" in MM extension ## **Screenshots/Recordings** ### **Installing snaps** https://github.com/user-attachments/assets/b21a7827-d4d2-4b72-bfa9-ea7ff9a08bd4 ### **Before** https://github.com/user-attachments/assets/f3b4d4fe-8cad-4c48-a314-a65a8fd2dc14 ### **After** https://github.com/user-attachments/assets/490e03d4-54db-48e5-b4b2-f9b16d1d257a ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > Adds gated Gator Permissions revocation flow: new routes/pages/components, selectors and hook, global menu/nav updates, env flag, locales, and comprehensive tests. > > - **Feature flag & config** > - Add `GATOR_PERMISSIONS_REVOCATION_ENABLED` env (builds.yml) and `isGatorPermissionsRevocationFeatureEnabled()` with tests. > - **Routing & navigation** > - Add routes: `GATOR_PERMISSIONS`, `TOKEN_TRANSFER_ROUTE`; register in router and analytics map. > - Update Global Menu “Connected sites” link to route to `GATOR_PERMISSIONS` when flag is on. > - Permissions page back button and title vary based on flag; header visibility utils updated for new routes. > - **UI** > - New pages: `GatorPermissionsPage`, `TokenTransferPage` (scaffolded), and `PermissionListItem` component. > - Gator Permissions page lists Sites and Token transfer categories (loading/empty states included). > - **Data layer** > - New selectors in `ui/selectors/gator-permissions` to deserialize/aggregate permissions. > - New hook `useGatorPermissions` to fetch/update permissions state. > - **Tests** > - Unit tests for env flag, selectors, hook; snapshots for new pages/components. > - E2E: permissions navigation and back behavior; global menu link target. > - **Locales** > - Add strings for `sites` and `tokenTransfer` in `en` and `en_GB`. > - **Fixtures** > - Extend mock state with gator permissions fields and serialized map. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ddf1657. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  --------- Co-authored-by: Tadej Vengust <[email protected]>

V00D00-child added 2 commits April 23, 2025 16:55

Add profile sync auth

4cc3f17

wire up connecting to message signing snap to complete profile sync a…

6145bc0

…uth flow

V00D00-child mentioned this pull request May 5, 2025

chore(deps): bump @metamask/message-signing-snap to v1.1.2 MetaMask/metamask-extension#32521

Merged

7 tasks

V00D00-child self-assigned this May 5, 2025

V00D00-child mentioned this pull request May 5, 2025

chore(deps): bump @metamask/message-signing-snap to v1.1.2 MetaMask/metamask-mobile#15141

Merged

7 tasks

V00D00-child assigned V00D00-child and unassigned V00D00-child May 5, 2025

add submodule to install local message signing snap

b37d7de

V00D00-child added 4 commits May 7, 2025 13:34

add storing permission to profile sync e2e

dfdeff5

render stored permissions on gator snap home page

b9474ae

add feature flag so storing permissions only happens when running sna…

2648b80

…p locally

restructure profileSyncManager module to allow for better testing

c1c2166

V00D00-child marked this pull request as ready for review May 8, 2025 18:51

V00D00-child requested a review from a team as a code owner May 8, 2025 18:51

V00D00-child changed the title ~~[DRAFT]Persisting Granted Permissions with MM Profile Sync~~ Persisting Granted Permissions with MM Profile Sync May 8, 2025

add more test

5eaaee3

jeffsmale90 reviewed May 13, 2025

View reviewed changes

address pr comments

be47726

V00D00-child requested a review from jeffsmale90 May 13, 2025 17:08

jeffsmale90 reviewed May 13, 2025

View reviewed changes

packages/permissions-provider-snap/src/profileSync/profileSync.ts Show resolved Hide resolved

V00D00-child added 3 commits May 14, 2025 11:44

use delegation hash as object key

8d8abec

fix merge conflict

120667f

fix shasum

6816a99

V00D00-child added 2 commits May 14, 2025 14:11

fix failing test

0bc698d

fix shasum

be85982

V00D00-child requested a review from jeffsmale90 May 14, 2025 18:59

jeffsmale90 reviewed May 14, 2025

View reviewed changes

generate object key by concatenating the delegation hashes, change fe…

8fb6dca

…ature name, do not call getUserProfile

V00D00-child requested a review from jeffsmale90 May 14, 2025 22:38

jeffsmale90 reviewed May 14, 2025

View reviewed changes

packages/permissions-provider-snap/src/profileSync/profileSync.ts Outdated Show resolved Hide resolved

use viem concat to combine delegation hashes

159dcd7

V00D00-child requested a review from jeffsmale90 May 15, 2025 14:22

jeffsmale90 approved these changes May 15, 2025

View reviewed changes

V00D00-child merged commit 08ca700 into main May 15, 2025
14 of 15 checks passed

V00D00-child deleted the feat/persist-permissions-with-profile-sync branch May 15, 2025 21:07

This was referenced Jun 30, 2025

feat: add gator permissions controller MetaMask/core#6033

Merged

[DRAFT]Feat/gator permissions revoke UI MetaMask/metamask-extension#33996

Closed

This was referenced Jul 10, 2025

Add new permissionsProvider_getGrantedPermissions RPC #108

Merged

Feat/trigger gator permissions revoke transaction MetaMask/metamask-extension#34373

Merged

V00D00-child mentioned this pull request Aug 19, 2025

feat: Introduce gator permissions revocation feature MetaMask/metamask-extension#35219

Merged

7 tasks

V00D00-child mentioned this pull request Aug 21, 2025

feat: Add feature flag for gator permissions page MetaMask/metamask-extension#35307

Merged

7 tasks

Uh oh!

Persisting Granted Permissions with MM Profile Sync #84

Persisting Granted Permissions with MM Profile Sync #84

Uh oh!

Conversation

V00D00-child commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Profile Sync SDK: OAuth 2.0 Authentication flow

Granted permissions store flow

Granted permissions retrieval flow(view)

Testing e2e locally

Task

Uh oh!

socket-security bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeffsmale90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeffsmale90 commented May 13, 2025

Uh oh!

socket-security bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

V00D00-child commented Apr 23, 2025 •

edited

Loading

socket-security bot commented May 6, 2025 •

edited

Loading

socket-security bot commented May 14, 2025 •

edited

Loading