Skip to content

fix: 13165 fix ledger blind sign error displayed not correctly#16200

Merged
dawnseeker8 merged 4 commits into
mainfrom
fix/13165-ledger-blind-sign-error
Jun 25, 2025
Merged

fix: 13165 fix ledger blind sign error displayed not correctly#16200
dawnseeker8 merged 4 commits into
mainfrom
fix/13165-ledger-blind-sign-error

Conversation

@dawnseeker8

@dawnseeker8 dawnseeker8 commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR will fix issue #13165
This PR will upgrade @metamask/eth-ledger-keyring-bridge library to correctly handle the blind signing not enable error and user reject transaction error.

This PR will wait library upgrade PR merged and release first. MetaMask/accounts#294

Related issues

Fixes: #13165

Manual testing steps

  1. Install MM Mobile
  2. Recover from SRP
  3. Add hardware wallet (Ledger Stax)
  4. Add Ledger account from account list
  5. Launch MM Test dApp
  6. Connect with Ledger account
  7. Disable blind signing on Ledger device
  8. Sign typed data v4
  9. Verify error

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label Jun 9, 2025
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E labels Jun 9, 2025
@github-actions

github-actions Bot commented Jun 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ca2ee1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5dbf79af-b67a-4dcf-92dc-6554ec9a994f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security

socket-security Bot commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​eth-ledger-bridge-keyring@​11.0.3 ⏵ 11.1.097 +310086 +196 +3100

View full report

@dawnseeker8 dawnseeker8 marked this pull request as ready for review June 19, 2025 09:59
@dawnseeker8 dawnseeker8 requested a review from a team June 19, 2025 09:59
@github-actions

github-actions Bot commented Jun 19, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4c2390b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/379e7add-e50c-44b7-9fbd-9e7be5d4ad79

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jun 19, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dawnseeker8 dawnseeker8 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 19, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Jun 19, 2025
@vivek-consensys vivek-consensys added the QA Passed QA testing has been completed and passed label Jun 20, 2025
MarioAslau
MarioAslau approved these changes Jun 24, 2025
View reviewed changes

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 24, 2025
@dawnseeker8 dawnseeker8 added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 00fe075 Jun 25, 2025
56 of 61 checks passed
@dawnseeker8 dawnseeker8 deleted the fix/13165-ledger-blind-sign-error branch June 25, 2025 15:27
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 25, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 25, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.51.0 Issue or pull request that will be included in release 7.51.0 team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] When blind signing is disabled and user attempts to sign typed data v4 on Ledger device, invalid data received error displayed

4 participants

@dawnseeker8 @MarioAslau @metamaskbot @vivek-consensys