Skip to content

chore: resolution for qs package#24235

Merged
tommasini merged 3 commits into
mainfrom
chore/bump-qs
Jan 5, 2026
Merged

chore: resolution for qs package#24235
tommasini merged 3 commits into
mainfrom
chore/bump-qs

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Jan 5, 2026

Description

  • Resolution for qs package
  • Remove qs package dependency

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Ensures a single, consistent qs version across the project.

  • Adds resolutions entry for qs at 6.14.1 in package.json
  • Updates dependencies qs from 6.12.1 to 6.14.1
  • Regenerates yarn.lock to use qs@6.14.1 and drop previous qs versions (6.12.1, 6.13.0, 6.14.0)

Written by Cursor Bugbot for commit f02c580. This will update automatically on new commits. Configure here.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Jan 5, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Jan 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment thread package.json
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​qs@​6.12.1 ⏵ 6.14.1100100 +1610089100

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeWalletPlatform
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

This PR upgrades the qs (query string) package from version 6.12.1 to 6.14.1. The qs library is used in two critical areas of the app:

  1. WalletConnect utilities (app/core/WalletConnect/wc-utils.ts) - for parsing WalletConnect URIs and query parameters
  2. DeeplinkManager (app/core/DeeplinkManager/utils/extractURLParams.ts) - for parsing deeplink URL parameters

This is a minor version upgrade (6.12.x → 6.14.x) which typically includes bug fixes and minor improvements without breaking API changes. The change also adds a resolution to ensure consistent version usage across the project.

While the qs library is stable and well-established, the affected code paths (WalletConnect and Deeplinks) are critical for wallet connectivity and external app interactions. Running SmokeCore and SmokeWalletPlatform tests will help verify that core wallet functionality and platform features continue to work correctly after this dependency upgrade.

No specific E2E tests for WalletConnect or Deeplinks were found in the test suite, so running the core smoke tests provides reasonable coverage for detecting any regressions in basic wallet operations that might be affected by query string parsing changes.

View GitHub Actions results

Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jan 5, 2026
@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 5, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 5, 2026

@tommasini tommasini added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit e256c8c Jan 5, 2026
96 of 97 checks passed
@tommasini tommasini deleted the chore/bump-qs branch January 5, 2026 13:17
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jan 5, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 5, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 5, 2026
@metamaskbot metamaskbot added release-7.62.0 Issue or pull request that will be included in release 7.62.0 release-7.61.6 Issue or pull request that will be included in release 7.61.6 and removed release-7.62.0 Issue or pull request that will be included in release 7.62.0 labels Jan 5, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-7.61.6 on PR. Adding release label release-7.61.6 on PR and removing other release labels(release-7.62.0), as PR was cherry-picked in branch 7.61.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.61.6 Issue or pull request that will be included in release 7.61.6 size-XS team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants