-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: remove private key reveal #24303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c94f175 to
d286067
Compare
app/components/Views/MultichainAccounts/sheets/RevealPrivateKey/RevealPrivateKey.tsx
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/RevealPrivateCredential/RevealPrivateCredential.tsx
Show resolved
Hide resolved
…om/MetaMask/metamask-mobile into refactor/remove-private-key-reveal
app/components/Views/MultichainAccounts/sheets/RevealPrivateKey/RevealPrivateKey.tsx
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/__snapshots__/SecuritySettings.test.tsx.snap
Outdated
Show resolved
Hide resolved
app/components/Views/RevealPrivateCredential/RevealPrivateCredential.test.tsx
Show resolved
Hide resolved
app/components/Views/RevealPrivateCredential/RevealPrivateCredential.test.tsx
Show resolved
Hide resolved
app/components/Views/RevealPrivateCredential/RevealPrivateCredential.test.tsx
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR makes significant changes to the private key and SRP reveal functionality:
The changes affect:
Selected tags:
Risk is medium because while these are security-sensitive changes, they appear to be a refactoring/removal of functionality rather than introducing new security-critical code paths. The unit tests have been updated comprehensively. |
|



Description
This PR removes code related to the legacy "Reveal Private Key" feature. This feature was deprecated with the release of BIP-44 and the implementation of a new "Reveal Private Key" flow.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1375
Manual testing steps
Screenshots/Recordings
Not applicable, no changes to the UI/UX
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes the legacy "Reveal Private Key" flow and consolidates credential reveal around SRP only.
Routes.SHEET.MULTICHAIN_ACCOUNT_DETAILS.REVEAL_PRIVATE_CREDENTIALwith{ account }params; drops old settings route/paramsRevealPrivateCredentialto SRP-only: removes private-key paths, copy, analytics, and UI; adds SRP warning test id and updates modal/tab actions accordinglyRevealPrivateKeysheet (header only) and removes its testsWritten by Cursor Bugbot for commit fe202fa. This will update automatically on new commits. Configure here.