-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: remove private key reveal #24303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gantunesr
wants to merge
18
commits into
main
Choose a base branch
from
refactor/remove-private-key-reveal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d286067
refactor: remove private key reveal
gantunesr ef565a0
chore: remove remaining code
gantunesr 8ecea8f
test: fix SRPQuiz
gantunesr b20690d
chore: remove component from RevealPrivateKey
gantunesr 54110b5
test: fix SecuritySettings
gantunesr d2a22ef
test: improve coverage
gantunesr 8c23c93
test: fix RevealPrivateCredential
gantunesr e07f22c
fix: lint
gantunesr f7cdb7d
fix: typo
gantunesr 2dadf9c
chore: update execution call order
gantunesr 0212b4f
Merge branch 'main' into refactor/remove-private-key-reveal
gantunesr 07cb001
Merge branch 'refactor/remove-private-key-reveal' of https://github.c…
gantunesr 07d0951
chore: update snapshot
gantunesr d65bdd9
test: revert react-native-scrollable-tab-view mock
gantunesr a9f43e3
test: make unit tests more strict
gantunesr f13e6bf
Merge branch 'main' into refactor/remove-private-key-reveal
gantunesr 8cb7784
test: improve unit tests
gantunesr fe202fa
Merge branch 'refactor/remove-private-key-reveal' of https://github.c…
gantunesr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 0 additions & 134 deletions
134
app/components/Views/MultichainAccounts/sheets/RevealPrivateKey/RevealPrivateKey.test.tsx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.