feat: rewards dropdown filter on activity tab

[sophieqgu]

Description

Support filter by event types in the Activity Tab

Changelog

CHANGELOG entry: Support filter by event types in the Activity Tab

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Medium risk because it changes the points-events fetching pipeline (new type query param, caching key changes, and request-cancellation logic), which could impact activity feed freshness/pagination if edge cases were missed.

Overview
Adds an Activity Tab dropdown filter that lets users fetch points activity by earn type, driven by season-provided activityTypes and new i18n strings.

Extends usePointsEvents and the rewards backend to support type-filtered points events: the hook now accepts type and enabled, cancels in-flight first-page/pagination requests when dependencies change, and the RewardsController/DataService include type in API requests and cache keys.

Updates SelectOptionSheet/OptionsSheet UI (design-system icon, sorted options with all pinned, new close header) and tweaks a few Rewards visuals (smaller icons, bonus text color), with substantial test/snapshot updates to cover filtering and new fetch behavior.

^{Written by Cursor Bugbot for commit 049b910. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.06%. Comparing base (0f5817f) to head (d4f6cc0).
⚠️ Report is 160 commits behind head on main.

Files with missing lines	Patch %	Lines
app/components/UI/Rewards/hooks/usePointsEvents.ts	87.80%	2 Missing and 3 partials ⚠️
...p/components/UI/SelectOptionSheet/OptionsSheet.tsx	85.71%	0 Missing and 2 partials ⚠️
...ontrollers/rewards-controller/RewardsController.ts	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #24910      +/-   ##
==========================================
+ Coverage   79.96%   80.06%   +0.09%     
==========================================
  Files        4257     4277      +20     
  Lines      109331   110146     +815     
  Branches    22889    23097     +208     
==========================================
+ Hits        87429    88189     +760     
+ Misses      15835    15821      -14     
- Partials     6067     6136      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[VGR-GIT]

@sophieqgu pushed a commit to solve an issue review bot had reported

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeRewards
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
This PR adds activity type filtering to the Rewards feature. The changes are primarily focused on:

1. RewardsController (Critical): Added type-based caching for points events, allowing separate cache entries for different activity types (SWAP, PERPS, CARD, etc.). This is a controller change but isolated to the Rewards domain.

2. Rewards UI Components: Added ActivityFilter component to ActivityTab, refactored usePointsEvents hook to support type filtering and enabled flag with request cancellation logic.

3. SelectOptionSheet (Shared Component): Visual/styling updates and alphabetical sorting. This component is used by LedgerConnect and FeatureFlagOverride, but the changes are backward-compatible (same props interface, just visual improvements).

The SmokeRewards tag is the appropriate choice because:

• All changes are within the Rewards domain (controller, UI components, hooks)
• The tag description explicitly covers "Activity tab displaying reward-earning actions"
• The changes add filtering capability to the activity events list

No other tags are needed because:

• No transaction/confirmation flow changes (SmokeConfirmationsRedesigned not needed)
• No account management changes (SmokeAccounts not needed)
• No network/chain changes (SmokeNetworkAbstractions not needed)
• No trading flow changes (SmokeTrade not needed)
• The SelectOptionSheet changes are visual only and don't affect Ledger functionality in a breaking way

Note: The SmokeRewards tests are currently skipped pending rewards system stabilization, but selecting this tag ensures the tests will run when they are enabled.

Performance Test Selection:
No performance tests are needed for this PR. The changes are focused on adding filtering functionality to the Rewards activity tab, which involves:

1. Cache key modifications in RewardsController - no impact on rendering performance
2. UI filter component addition - simple dropdown, not a performance-critical component
3. Hook refactoring for request cancellation - improves behavior but doesn't affect measured performance metrics

The changes don't affect:

• Account list rendering (@PerformanceAccountList)
• Onboarding flows (@PerformanceOnboarding)
• Login/unlock (@PerformanceLogin)
• Swap flows (@PerformanceSwaps)
• App launch (@PerformanceLaunch)
• Asset/balance loading (@PerformanceAssetLoading)
• Predict markets (@PerformancePredict)
• Perpetuals trading (@PerformancePreps)

The Rewards feature is a separate, isolated feature that doesn't have dedicated performance tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud