fix: support webcredentials cp-7.71.0#27741
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
revert the ios client id so that this pr is purely package patch update. |
|
✅ E2E Fixture Validation — Schema is up to date |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are iOS-specific infrastructure changes with no modifications to app logic, UI components, controllers, or test infrastructure. The changes improve web authentication session handling on newer iOS versions and add webcredentials domain association. No existing E2E tests cover Performance Test Selection: |
|




Description
This pr patch the expo-web-browser to support https redirect schema
Taking reference from expo-web-browser sdk 55
https://github.com/expo/expo/blob/308031a6665f885811760aff7aebb68aea4a846a/packages/expo-web-browser/ios/WebAuthSession.swift#L36
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7148
PR list
Part 1/ 4 - #27741
Part 2/ 4 - #27848
Part 3/ 4 - #27850
Part 4/ 4 - #27875
Changelog
CHANGELOG entry: expo-web-browser support https redirect scheme
CHANGELOG entry: use webcredential for ios google login
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it changes iOS
ASWebAuthenticationSessioncallback configuration and entitlements, which can affect login/redirect flows and associated-domain behavior.Overview
Enables HTTPS redirect-based auth callbacks on iOS by patching
expo-web-browser’sWebAuthSessionto use iOS 17.4+/macOS 14.4+.https(host:path)callbacks when theredirectUrlishttps, falling back to the legacycallbackURLSchemebehavior otherwise.Updates iOS entitlements (
MetaMask.entitlementsandMetaMaskDebug.entitlements) to includewebcredentials:link.metamask.io, and wires the patch into the build via a Yarnresolutionsentry plus correspondingyarn.lockchanges.Written by Cursor Bugbot for commit 7730be3. This will update automatically on new commits. Configure here.