Skip to content

fix: prompt login not supported#27743

Closed
ieow wants to merge 16 commits into
mainfrom
cw/prompt-login-not-supported
Closed

fix: prompt login not supported#27743
ieow wants to merge 16 commits into
mainfrom
cw/prompt-login-not-supported

Conversation

@ieow
Copy link
Copy Markdown
Contributor

@ieow ieow commented Mar 20, 2026

Description

This pr build on top of #27741 to add guard for iOS version 17.4 and above
Google login in iOS will not be supported for version below 17.4

clean up some unused variables

Merge PR #27741 before merge this PR

Changelog

CHANGELOG entry: add guard for ios google login. below iOS 17.4 is not supported

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches onboarding OAuth flow and Google login configuration selection, which can affect sign-in behavior on iOS. Risk is mitigated by feature-flag gating and expanded unit test coverage, but version/config branching could still regress edge cases.

Overview
Adds an iOS < 17.4 Google login warning during onboarding: before starting Google OAuth, the app now shows a non-interactable SuccessErrorSheet and then continues the login flow after dismissal.

Introduces a remote+env feature flag (legacyIosGoogleConfigEnabled / MM_LEGACY_IOS_GOOGLE_CONFIG_ENABLED) and new helpers (shouldUseLegacyIosGoogleConfig, getIosGoogleConfig) to choose between legacy iOS Google OAuth config vs the web/universal-link config, and updates the login handler factory to use this shared config.

Adds shared navigation helpers (navigateToSuccessErrorSheet and promise-based navigateToSuccessErrorSheetPromise), a semver-based Device.comparePlatformVersionTo, updates Google OAuth request to use Prompt.SelectAccount, and expands tests/localized strings to cover the new branching and warning copy.

Written by Cursor Bugbot for commit 9e697be. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Mar 20, 2026
@ieow ieow mentioned this pull request Mar 20, 2026
7 tasks
@ieow ieow marked this pull request as ready for review March 20, 2026 16:18
@ieow ieow requested a review from a team as a code owner March 20, 2026 16:18
Comment thread app/components/Views/Onboarding/index.tsx Outdated
Cal-L
Cal-L previously approved these changes Mar 20, 2026
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added size-L and removed size-M labels Mar 23, 2026
Comment thread app/components/Views/SuccessErrorSheet/index.tsx Outdated
Comment thread app/components/Views/SuccessErrorSheet/index.tsx Outdated
Comment thread app/core/OAuthService/OAuthLoginHandlers/index.ts Outdated
Comment thread app/components/Views/Onboarding/index.test.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main or a release branch (base: cw/webcredentials)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot removed the size-L label Mar 24, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread locales/languages/en.json
"no_internet_connection_button": "Try again"
"no_internet_connection_button": "Try again",
"ios_google_login_not_supported_title": "Login not supported",
"ios_google_login_not_supported_description": "Google login below iOS 17.4 will not be supported soon. Please update your iOS version or login with Android/Extension for rehydration. You are advice to backup your SRP if proceed with iOS google login.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User-facing text has grammar errors

Medium Severity

The ios_google_login_not_supported_description string contains two grammar errors: "You are advice to backup" (should be "advised") and "if proceed with" (should be "if you proceed with" or "if proceeding with"). This is a user-facing warning in a financial wallet app where unclear or broken language can erode user trust, especially when advising users to back up their SRP before a potentially unsupported login flow.

Fix in Cursor Fix in Web

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
15 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

Base automatically changed from cw/webcredentials to main March 24, 2026 09:37
@ieow ieow dismissed Cal-L’s stale review March 24, 2026 09:37

The base branch was changed.

@ieow ieow requested a review from a team as a code owner March 24, 2026 09:37
@ieow
Copy link
Copy Markdown
Contributor Author

ieow commented Mar 26, 2026

close in favor or pr #27875

@ieow ieow closed this Mar 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants