fix: prompt login not supported#27743
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main or a release branch (base: cw/webcredentials) All E2E tests pre-selected. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| "no_internet_connection_button": "Try again" | ||
| "no_internet_connection_button": "Try again", | ||
| "ios_google_login_not_supported_title": "Login not supported", | ||
| "ios_google_login_not_supported_description": "Google login below iOS 17.4 will not be supported soon. Please update your iOS version or login with Android/Extension for rehydration. You are advice to backup your SRP if proceed with iOS google login.", |
There was a problem hiding this comment.
User-facing text has grammar errors
Medium Severity
The ios_google_login_not_supported_description string contains two grammar errors: "You are advice to backup" (should be "advised") and "if proceed with" (should be "if you proceed with" or "if proceeding with"). This is a user-facing warning in a financial wallet app where unclear or broken language can erode user trust, especially when advising users to back up their SRP before a potentially unsupported login flow.
|
✅ E2E Fixture Validation — Schema is up to date |
|
|
close in favor or pr #27875 |





Description
This pr build on top of #27741 to add guard for iOS version 17.4 and above
Google login in iOS will not be supported for version below 17.4
clean up some unused variables
Merge PR #27741 before merge this PR
Changelog
CHANGELOG entry: add guard for ios google login. below iOS 17.4 is not supported
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches onboarding OAuth flow and Google login configuration selection, which can affect sign-in behavior on iOS. Risk is mitigated by feature-flag gating and expanded unit test coverage, but version/config branching could still regress edge cases.
Overview
Adds an iOS < 17.4 Google login warning during onboarding: before starting Google OAuth, the app now shows a non-interactable
SuccessErrorSheetand then continues the login flow after dismissal.Introduces a remote+env feature flag (
legacyIosGoogleConfigEnabled/MM_LEGACY_IOS_GOOGLE_CONFIG_ENABLED) and new helpers (shouldUseLegacyIosGoogleConfig,getIosGoogleConfig) to choose between legacy iOS Google OAuth config vs the web/universal-link config, and updates the login handler factory to use this shared config.Adds shared navigation helpers (
navigateToSuccessErrorSheetand promise-basednavigateToSuccessErrorSheetPromise), a semver-basedDevice.comparePlatformVersionTo, updates Google OAuth request to usePrompt.SelectAccount, and expands tests/localized strings to cover the new branching and warning copy.Written by Cursor Bugbot for commit 9e697be. This will update automatically on new commits. Configure here.