Update input validation#110
Merged
Merged
Conversation
10 tasks
6 tasks
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jeffsmale90
reviewed
Aug 1, 2025
jeffsmale90
left a comment
Contributor
There was a problem hiding this comment.
Looking good!
I'm definitely looking forward to de-duplicating the permission type logic!
…15-permissions into chore/number-validation
jeffsmale90
previously approved these changes
Aug 5, 2025
jeffsmale90
left a comment
Contributor
There was a problem hiding this comment.
Snapshot conflicts aside, this looks great!
| setStartTime(null); | ||
| } else { | ||
| setStartTime(Number(inputValue)); | ||
| } |
There was a problem hiding this comment.
Bug: Invalid Input Handling Causes NaN StartTime
The handleStartTimeChange function in ERC20TokenStreamForm, NativeTokenPeriodicForm, ERC20TokenPeriodicForm, and NativeTokenStreamForm components directly converts user input to a number without validating if it's a valid numeric string. This can result in NaN being set as the startTime state for non-numeric inputs, leading to confusing validation errors.
Additional Locations (3)
jeffsmale90
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we update input validation from the point of developer setting permission parameters:
Manual testing steps
Screenshots/Recordings
Before
Uploading Screen Recording 2025-07-31 at 13.01.09.mov…
After
Screen.Recording.2025-07-31.at.12.56.47.mov
Pre-merge author checklist
Pre-merge reviewer checklist