fix few issues with byc #56
Conversation
|
|
||
| xy = np.array(points_src).T | ||
| uv = np.array(points_dst).T | ||
|
|
||
| indices, weights = _linear_weights_cropped_domain(xy, uv) | ||
|
|
||
| return _icon2regular(field, dst, indices, weights) | ||
| return _icon2regular(field, dst, indices, weights).assign_coords( | ||
| lon=(("y", "x"), gx), lat=(("y", "x"), gy) |
There was a problem hiding this comment.
should this be lon or longitude?
There was a problem hiding this comment.
this only applies if the dst grid is defined in geolatlon CRS
| @@ -485,11 +486,13 @@ def iconremap( | |||
|
|
|||
| gx, gy = np.meshgrid(dst.x, dst.y) | |||
| transformer_dst = Transformer.from_crs(dst.crs.wkt, utm_crs) | |||
| points_dst = transformer_dst.transform(gx.flat, gy.flat) | |||
| points_dst = transformer_dst.transform(gy.flat, gx.flat) | |||
There was a problem hiding this comment.
Which coordinate system are you using for your test?
There was a problem hiding this comment.
okay, I would rather add always_xy to the previous line because this change is breaking support for all CRSs that are in the traditional order
| @@ -35,9 +35,6 @@ def speed(u: xr.DataArray, v: xr.DataArray) -> xr.DataArray: | |||
| the horizontal wind speed [m/s]. | |||
|
|
|||
| """ | |||
| if u.origin_x != 0.0 or v.origin_y != 0.0: | |||
There was a problem hiding this comment.
as we transition towards ICON native grid support and or other grids, I think we should decommission the C staggering (i.e. origin_x, origin_y). Still variables will be staggered in z
There was a problem hiding this comment.
Unless we drop support for COSMO data from the archive, this will need to live on. The meaning of the origin_x and origin_y attributes need to be defined in the context of the ICON native grid. Then, we can adapt the checks.
Purpose
Attempt to fix the interpolation using byc.
Remove the sections below which do not apply.
Not yet ready, the test for icon-ch2 is failing.
Checklist
Before submitting this PR, please make sure:
Additionally, if the PR updates the version of the package
Review
For the review process follow the guidelines at Checklist