Skip to content

Compilation: Add AllowInvalidTop flag - #1900

Merged
MikePopoloski merged 1 commit into
MikePopoloski:masterfrom
AndrewNolte:AndrewNolte/stack/17
Jul 16, 2026
Merged

Compilation: Add AllowInvalidTop flag#1900
MikePopoloski merged 1 commit into
MikePopoloski:masterfrom
AndrewNolte:AndrewNolte/stack/17

Conversation

@AndrewNolte

@AndrewNolte AndrewNolte commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.04%. Comparing base (cad88da) to head (15184f5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
source/ast/symbols/InstanceSymbols.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
- Coverage   96.04%   96.04%   -0.01%     
==========================================
  Files         247      247              
  Lines       56635    56645      +10     
==========================================
+ Hits        54396    54405       +9     
- Misses       2239     2240       +1     
Files with missing lines Coverage Δ
include/slang/ast/Compilation.h 100.00% <100.00%> (ø)
include/slang/ast/symbols/InstanceSymbols.h 100.00% <ø> (ø)
source/ast/Compilation.cpp 96.70% <100.00%> (+<0.01%) ⬆️
source/ast/symbols/InstanceSymbols.cpp 96.92% <92.30%> (-0.08%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad88da...15184f5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewNolte
AndrewNolte marked this pull request as draft July 15, 2026 13:54
@AndrewNolte
AndrewNolte force-pushed the AndrewNolte/stack/17 branch from e3b7da7 to 2663adf Compare July 15, 2026 13:54
@AndrewNolte
AndrewNolte marked this pull request as ready for review July 15, 2026 13:54
@AndrewNolte
AndrewNolte marked this pull request as draft July 15, 2026 14:50
@AndrewNolte
AndrewNolte marked this pull request as ready for review July 15, 2026 14:50
Comment thread source/ast/symbols/ParameterBuilder.h Outdated
Comment thread tests/unittests/ast/InterfaceTests.cpp
@MikePopoloski

Copy link
Copy Markdown
Owner

Also need to update Python bindings for the new flag.

@AndrewNolte
AndrewNolte marked this pull request as draft July 15, 2026 17:09
@AndrewNolte
AndrewNolte force-pushed the AndrewNolte/stack/17 branch 2 times, most recently from 9386e3a to 59b1485 Compare July 15, 2026 17:09
@AndrewNolte
AndrewNolte marked this pull request as ready for review July 15, 2026 17:09
@AndrewNolte
AndrewNolte marked this pull request as draft July 15, 2026 17:18
@AndrewNolte
AndrewNolte force-pushed the AndrewNolte/stack/17 branch from 59b1485 to 3c571d4 Compare July 15, 2026 17:18
@AndrewNolte
AndrewNolte marked this pull request as ready for review July 15, 2026 17:18
This flag sets error types for unset top level params, allowing for better diagnostics when not in a full design context.

stack-info: PR: MikePopoloski#1900, branch: AndrewNolte/stack/17
@MikePopoloski
MikePopoloski force-pushed the AndrewNolte/stack/17 branch from 3c571d4 to 15184f5 Compare July 16, 2026 12:18
@MikePopoloski
MikePopoloski merged commit b618557 into MikePopoloski:master Jul 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants