Compilation: Add AllowInvalidTop flag - #1900
Merged
MikePopoloski merged 1 commit intoJul 16, 2026
Merged
Conversation
AndrewNolte
force-pushed
the
AndrewNolte/stack/17
branch
from
July 14, 2026 19:56
77f9f50 to
73090d4
Compare
This was referenced Jul 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
- Coverage 96.04% 96.04% -0.01%
==========================================
Files 247 247
Lines 56635 56645 +10
==========================================
+ Hits 54396 54405 +9
- Misses 2239 2240 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AndrewNolte
marked this pull request as draft
July 15, 2026 13:54
AndrewNolte
force-pushed
the
AndrewNolte/stack/17
branch
from
July 15, 2026 13:54
e3b7da7 to
2663adf
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 13:54
AndrewNolte
marked this pull request as draft
July 15, 2026 14:50
AndrewNolte
marked this pull request as ready for review
July 15, 2026 14:50
Owner
|
Also need to update Python bindings for the new flag. |
AndrewNolte
marked this pull request as draft
July 15, 2026 17:09
AndrewNolte
force-pushed
the
AndrewNolte/stack/17
branch
2 times, most recently
from
July 15, 2026 17:09
9386e3a to
59b1485
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 17:09
AndrewNolte
marked this pull request as draft
July 15, 2026 17:18
AndrewNolte
force-pushed
the
AndrewNolte/stack/17
branch
from
July 15, 2026 17:18
59b1485 to
3c571d4
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 17:18
This flag sets error types for unset top level params, allowing for better diagnostics when not in a full design context. stack-info: PR: MikePopoloski#1900, branch: AndrewNolte/stack/17
MikePopoloski
force-pushed
the
AndrewNolte/stack/17
branch
from
July 16, 2026 12:18
3c571d4 to
15184f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
View individual changes
Compilation: Add AllowInvalidTop flag
This flag sets error types for unset top level params, allowing for better diagnostics when not in a full design context.