Compilation: Add CheckUninstantiated flag - #1901
Merged
MikePopoloski merged 1 commit intoJul 28, 2026
Merged
Conversation
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Jul 14, 2026
stack-info: PR: MikePopoloski#1901, branch: AndrewNolte/stack/18
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
from
July 14, 2026 19:56
007b97f to
54a6363
Compare
This was referenced Jul 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 247 247
Lines 56693 56708 +15
=======================================
+ Hits 54455 54470 +15
Misses 2238 2238
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AndrewNolte
marked this pull request as draft
July 15, 2026 13:54
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Jul 15, 2026
This compilation flag enables more checks to be done in untaken generate branches, or gen loops with invalid loop params. stack-info: PR: MikePopoloski#1901, branch: AndrewNolte/stack/18
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
from
July 15, 2026 13:54
a13e283 to
83f13bc
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 13:54
AndrewNolte
marked this pull request as draft
July 15, 2026 14:50
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
from
July 15, 2026 14:50
89466bd to
f49a2fb
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 14:50
AndrewNolte
marked this pull request as draft
July 15, 2026 17:09
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
2 times, most recently
from
July 15, 2026 17:09
4f47b47 to
7a1c229
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 17:09
AndrewNolte
marked this pull request as draft
July 15, 2026 17:18
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
from
July 15, 2026 17:18
7a1c229 to
ae0d401
Compare
AndrewNolte
marked this pull request as ready for review
July 15, 2026 17:18
| bool isValue() const; | ||
|
|
||
| /// Determines whether this symbol is instantiated. | ||
| bool isInstantiated() const; |
Owner
There was a problem hiding this comment.
This is a confusing method to add since Scopes have an isUninstantiated method already. I think it should stay a helper in the Compilation file.
|
|
||
| result->entries = entries.copy(comp); | ||
| if (entries.empty()) { | ||
| // Keep result->entries empty so indexed lookup (g[0], etc.) still reports |
Owner
There was a problem hiding this comment.
This whole comment is pretty hard to understand. It's also unclear to me why the else block was removed, this should be the same behavior right?
Contributor
Author
There was a problem hiding this comment.
createBlock() adds to entries, so the loop actually does get traversed. This makes it such that AST Visitors can visit this uninstantiated scope, but it's still not accessible by a gen_arr[0] ref bc it's an uninstantiated block
Contributor
Author
There was a problem hiding this comment.
But it doesn't add to result->entries. I could change it to just result->addMember(entries[0]) to avoid the loop.
AndrewNolte
marked this pull request as draft
July 16, 2026 19:15
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
3 times, most recently
from
July 16, 2026 19:17
a4ddc02 to
0421c30
Compare
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
3 times, most recently
from
July 21, 2026 14:16
3495ade to
5a75153
Compare
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
2 times, most recently
from
July 22, 2026 15:50
8813363 to
015e587
Compare
This compilation flag enables more checks to be done in untaken generate branches, or gen loops with invalid loop params. stack-info: PR: MikePopoloski#1901, branch: AndrewNolte/stack/18
AndrewNolte
force-pushed
the
AndrewNolte/stack/18
branch
from
July 23, 2026 17:37
015e587 to
c2c4ae4
Compare
This was referenced Jul 27, 2026
AndrewNolte
marked this pull request as ready for review
July 27, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
View individual changes
Compilation: Add CheckUninstantiated flag
This compilation flag enables more checks to be done in untaken generate branches, or gen loops with invalid loop params.