Instances: Split default interface port connections

[AndrewNolte]

Stacked PRs:

• --allow-toplevel-iface-ports: Apply $static_assert iface param overrides #1910
• ->Instances: Split default interface port connections #1909
• Analysis: Diag ranges instead of locs for unused vars #1902
• Compilation: Add CheckUninstantiated flag #1901

---

View individual changes

Instances: Split default interface port connections

Splits up behavior for instantiating default interface port connections into a separate file.
This is so it's more clear which code is used in the abnormal / slang extensions flow.
I'm planning on adding $static_assert iface param pinning in a followup that requires additional code.

[codecov]

Codecov Report

❌ Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.05%. Comparing base (3c984ff) to head (a113d1b).

Files with missing lines	Patch %	Lines
source/ast/symbols/DefaultIfacePortConnections.cpp	96.07%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1909   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         247      248    +1     
  Lines       56693    56712   +19     
=======================================
+ Hits        54455    54474   +19     
  Misses       2238     2238           

Files with missing lines	Coverage Δ
include/slang/analysis/AnalysisManager.h	100.00% <ø> (ø)
include/slang/ast/Compilation.h	100.00% <100.00%> (ø)
source/analysis/AnalysisManager.cpp	88.32% <100.00%> (+0.18%)	⬆️
source/analysis/AnalysisScopeVisitor.h	100.00% <100.00%> (ø)
source/ast/Compilation.cpp	96.73% <100.00%> (+0.03%)	⬆️
source/ast/symbols/BlockSymbols.cpp	98.48% <100.00%> (+<0.01%)	⬆️
source/ast/symbols/InstanceSymbols.cpp	96.97% <100.00%> (+0.04%)	⬆️
source/ast/symbols/DefaultIfacePortConnections.cpp	96.07% <96.07%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c984ff...a113d1b. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MikePopoloski]

Not sure this is really necessary. It's only a hundred lines of code, and you're not adding that much more in the followup diff. The new file name is also pretty awkward.