Skip to content

fix: #64 call to parent OnErrorAsync in RaygunErrorBoundary#65

Merged
miquelbeltran merged 2 commits intomainfrom
fix/64-error-boundary
Jan 22, 2025
Merged

fix: #64 call to parent OnErrorAsync in RaygunErrorBoundary#65
miquelbeltran merged 2 commits intomainfrom
fix/64-error-boundary

Conversation

@miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jan 22, 2025

fix: #64 call to parent OnErrorAsync in RaygunErrorBoundary

Description 📝

  • Purpose: RaygunErrorBoundary.OnErrorAsync only called to the internal Raygun logger and ignored the default ErrorBoundaryLogger.
  • Approach: Call to the parent OnErrorAsync so the default implementation works independently to Raygun's configuration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Updates

  • Add call to base.OnErrorAsync to the RaygunErrorBoundary implementations for WebAssembly, Maui and Server.

Screenshots 📷

Error captured by the parent ErrorBoundary as appearing on a Blazor Maui Windows app:

image

Same error as appears on Raygun

image

Test plan 🧪

  • Tested on samples app for Maui (Windows), WebAssembly and Server

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran marked this pull request as ready for review January 22, 2025 09:39
/// <returns></returns>
protected override async Task OnErrorAsync(Exception exception)
{
Console.WriteLine("OnErrorAsync");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this logline as it may have been added by mistake

Copy link

@phillip-haydon phillip-haydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@miquelbeltran miquelbeltran merged commit b78d260 into main Jan 22, 2025
3 checks passed
@miquelbeltran miquelbeltran deleted the fix/64-error-boundary branch January 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RaygunErrorBoundary: log exceptions

2 participants