DC 2.0 S9: Demolition — remove Fluent Bit packages and flb_* layer - #270
Merged
Minipada merged 6 commits intoJul 27, 2026
Merged
Conversation
…tions, flb_* layer The Bridge + Vector data plane (#242-#249) fully replaces the embedded-Fluent-Bit architecture, so per ADRs 0001/0003 this deletes fluent_bit_vendor, fluent_bit_plugins (the last Go code in the repo), and dc_destinations (destination_server plus all twelve flb_* pluginlib Destination plugins) along with dc_core's now-dead Destination base class. Also removes the go-fmt pre-commit hook, stale build/CI references to the deleted packages, the obsolete destination_plugins/destination_server requirement specs, and updates every doc page that still described the old architecture in the present tense (concepts, configuration examples, FAQ, groups, introduction, measurements) to the dc_bridge/Vector model. dc_demos and its docs, plus the standalone docker-compose demo infrastructure, are intentionally left flb_*-shaped here — that rework is issue #251, which is blocked by this one. Closes #250 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Comments should describe the current architecture, not cite the removal task that got it there — that belongs in the PR description and rots as history moves on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
MinIO's community edition is no longer maintained (already the stated reason destinations.md recommends RustFS as the self-hosted S3-compatible store). The examples this PR just rewrote for DC 2.0 (camera upload Destination, groups tags, introduction diagram, tcp_health/measurements docs, and the file-uploads example in destinations.md/dc_params.yaml) still named the destination "minio" — switch them to "rustfs" for consistency with that recommendation. dc_demos, its docs, and the standalone MinIO docker-compose infra are left as-is; that's issue #251's scope. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
…emoval Ran the real verification progress.txt had left open: a fresh colcon build across all 14 remaining packages via tools/e2e/scripts/build.sh, then colcon test against live Postgres/RustFS test stores via tools/e2e/scripts/test.sh (the same scripts ci.yaml calls) — 84 tests, 0 failures. Closes out acceptance criteria 3 and 4 with an actual run instead of just inspection. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Minipada
force-pushed
the
feature/250-dc-2-0-s9-demolition-remove-fluent-bit-p
branch
from
July 26, 2026 23:01
729121a to
48c816c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #270 +/- ##
=======================================
Coverage 32.06% 32.06%
=======================================
Files 73 73
Lines 4324 4324
=======================================
Hits 1386 1386
Misses 2938 2938
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Supervisor.RestartsProcessThatExitsOnItsOwn and RespectsRestartBackoff asserted the supervised child had exited after a fixed sleep_for(200-300ms) — a margin that assumes fork+exec+process-teardown always gets scheduled that fast, which a shared/loaded CI runner can blow (observed failing once on GitHub Actions right after a full workspace build, while passing locally and on the prior jazzy CI run with identical code). Replace the fixed-sleep-then-assert with the poll-until-condition-or-deadline pattern this same test file already uses correctly in SupervisedProcessDiesWithItsSpawner: wait_until() polls every 10ms up to a 5s deadline instead of guessing a wall-clock margin, so it only waits as long as actually needed and still fails loudly on a real hang. Verified: 30/30 clean runs of supervisor_test in the same Podman workspace image CI uses, after an incremental `colcon build --packages-select dc_bridge`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Minipada
force-pushed
the
feature/250-dc-2-0-s9-demolition-remove-fluent-bit-p
branch
from
July 26, 2026 23:30
5328c88 to
6b7973a
Compare
Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
4 tasks
Minipada
deleted the
feature/250-dc-2-0-s9-demolition-remove-fluent-bit-p
branch
July 27, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fluent_bit_vendor,fluent_bit_plugins(the last Go code in the repo), and the entiredc_destinationspackage (destination_server+ all twelveflb_*pluginlib Destination plugins +rcl.cpp) — fully superseded by the Bridge + Vector data plane from DC 2.0 S1: Port C++ core to ROS 2 Jazzy (Fluent Bit packages ignored) #242-DC 2.0 S8: Zero-loss E2E harness + Jazzy CI #249, per ADRs 0001/0003.dc_core::Destinationpluginlib base class, thego-fmtpre-commit hook, and every build/CI/requirements-spec reference to the deleted packages.destination_serverarchitecture in the present tense (concepts, configuration examples, FAQ, groups, introduction, measurements, destinations) to thedc_bridge/Vector model, and switches example Destination names from MinIO to RustFS (MinIO's community edition is no longer maintained).dc_demos/its docs and the standalone docker-compose demo infraflb_*/MinIO-shaped — that's issue DC 2.0 S10: Demos rework on the new pipeline #251 ("Demos rework"), which is blocked by this PR.A tree-wide
grepforfluent_bit|flb_|FLB_|FluentBitafter these changes only turns up the intentional exceptions:dc_demos/its docs (#251's scope),docs/adr/*(immutable decision records),CLAUDE.md/CONTEXT.md's deliberate comparative/historical framing, andprogress.txt's own prior entries.Closes #250
Test plan
.cpp/.hpp/CMakeLists.txt/package.xmlfordc_destinations/destination_server/DestinationServerpost-deletion — only three descriptive comments indc_measurements/measurement.hpp, reworded to reference "the Bridge".colcon buildviatools/e2e/scripts/build.sh(Podman) — all 14 remaining packages built clean.colcon testviatools/e2e/scripts/test.shagainst live Postgres + RustFS test stores (same asci.yaml) — 84 tests, 0 errors, 0 failures, 0 skipped, includingdc_bridge's store-backed tests (which hard-fail rather than skip, so this genuinely exercised them).🤖 Generated with Claude Code
https://claude.ai/code/session_01StNXjcK7b1kY2KYRd8qN6N