feat(pd): improve lifecycle supervision, health checks, and multimodal support - #1412
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Prefill/Decode (PD) disaggregated deployments, with a focus on container lifecycle management, topology-aware health reporting, connection liveness, KV transfer configuration, and multimodal correctness.
Process lifecycle and cleanup
SubmoduleManagerPD connectivity and configuration
--pd_trans_modewithncclandnixloptions; default toncclLIGHTLLM_WEBSOCKET_MAX_SIZEto 128 MiBNO_PROXYrequirements for same-host or internal PD WebSocket trafficTopology-aware health checks
--pd_master_modeelastic: ready when at least one Prefill and one Decode node are registered2p1d: ready only when the exact node counts are registered/readinessreflect node readiness/healthcombine inference progress, topology readiness, and P/D node health checksMultimodal correctness
max_image_pixelsanddisable_image_resizeto match PD Mastertorch.int64for modelinput_idsso virtual multimodal token IDs fit safelyDeployment scripts and documentation
test/start_scripts/qwen35/qwen35_pd_2p1d.shValidation
25 passed2P/1Ddeployment reached healthy and ready state/healthReview follow-ups before merge
pd_master_modestrings instead of accepting malformed suffixes such as2p1xmodel_createdfor PD Master so/v1/modelsdoes not passcreated=NonetoModelCard