Skip to content

Comments

[improve] Add M-a/C-a event for QTMLineEdit#2233

Merged
JackYansongLi merged 3 commits intoMoganLab:branch-1.2from
JimZhouZZY:branch-1.2
Jun 5, 2025
Merged

[improve] Add M-a/C-a event for QTMLineEdit#2233
JackYansongLi merged 3 commits intoMoganLab:branch-1.2from
JimZhouZZY:branch-1.2

Conversation

@JimZhouZZY
Copy link
Contributor

@JimZhouZZY JimZhouZZY commented Jun 3, 2025

What

Added support for Cmd+A / Ctrl+A key events in QTMLineEdit to select all text in the search toolbar.

Related: #2232

Why

Cmd+A / Ctrl+A is a native QLineEdit behavior in Qt. Supporting it improves usability by allowing users to quickly modify their search query. This standard interaction should not be ignored, I guess.

How to test your changes

  1. Build the project.
  2. Open the search toolbar using Cmd+f / Ctrl+f.
  3. Enter any text.
  4. Press Cmd+a / Ctrl+a to ensure all text is selected.

Copy link
Contributor

@JackYansongLi JackYansongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的代码没有format,我们用的是clang-format-16。如果你是macOS可以

brew install llvm@16

然后再在mogan的根目录

bin/format

JackYansongLi
JackYansongLi previously approved these changes Jun 5, 2025
@JimZhouZZY
Copy link
Contributor Author

你的代码没有format,我们用的是clang-format-16。如果你是macOS可以

brew install llvm@16

然后再在mogan的根目录

bin/format

好的

@JackYansongLi JackYansongLi self-requested a review June 5, 2025 05:26
@JackYansongLi
Copy link
Contributor

JackYansongLi commented Jun 5, 2025

你的代码没有format,我们用的是clang-format-16。如果你是macOS可以
brew install llvm@16
然后再在mogan的根目录
bin/format

好的

记得检查下版本,我们强制使用这个版本的,macOS默认的版本太高了

clang-format --version                                                                                                                                        ─╯
Homebrew clang-format version 16.0.6

@JackYansongLi JackYansongLi dismissed their stale review June 5, 2025 05:32

needs format

Copy link
Contributor

@JackYansongLi JackYansongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackYansongLi JackYansongLi merged commit 6a70f4e into MoganLab:branch-1.2 Jun 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants