Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added constants VECTOR3_HALF and VECTOR3_NEGATIVE_ONE #56

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Added constants VECTOR3_HALF and VECTOR3_NEGATIVE_ONE #56

merged 4 commits into from
Feb 12, 2025

Conversation

AlexDenfordSkyboxLabs
Copy link
Contributor

Requested from Editor team.

rlandav
rlandav approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but there is a prettier issue? The auto formatting change that was made seems a bit suspicious. Do npm run lint -- --fix in case your VSCode has some configuration doing an override for some reason.

@AlexDenfordSkyboxLabs
Copy link
Contributor Author

Not sure with the formatting, running lint fix was just crashing after it said there was a prettier issue. Fixed it manually.

@rlandav rlandav merged commit b56d6fe into main Feb 12, 2025
2 checks passed
@rlandav rlandav deleted the vector3-constants branch February 12, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlandav rlandav rlandav approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexDenfordSkyboxLabs @rlandav