Refactored the distributed_eval from the contrib package #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer and as it was
cgoina
commented
Dec 13, 2025
| normalize_args={}, | ||
| cellpose_eval_args={}, | ||
| worker_logs_dir=None, | ||
| ): |
Author
There was a problem hiding this comment.
This method only runs the distributed eval - no label merging. The reason for this is that there is a dask cluster resize between the eval and label merge, but in some packages where I want to use this I don't have the cluster resize option. Also I see the existing cluster annotation as a leaky abstraction - it says that you don't have to know anything about the cluster but you do and if you want it you need to pass me the proper parameters. So my option here is to make the dask Client argument as mandatory. If you don't want to distribute anything you can simply call the existing read_and_segment method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GFleishman, @carsen-stringer , @mrariden
The purpose of this PR is to refactor the distributed_eval method so that I can use the code from this package directly in the command line tools package used by Janelia's Nextflow cellpose pipeline, which currently pretty much duplicate this code.
The main change was to no longer create the temporary zarr inside the distributed_eval but instead create it in the caller and pass it to the method.