Fixes negative inclination circularization from Autoascent #2054
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occurs when using the autoascent feature for negative inclination orbits. Namely, the circularization burn was explicitly trying to achieve the _abs(inclination)_ instead of the target. The bug was fixed by removing the `Math.Abs()` from the OrbitalManeuverCalculator.DeltaVToChangeInclination input.
DTaskiran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is described in Issue #2048.
The bug occurred when using the Autoascent feature for negative inclination orbits. Namely, the circularization burn was explicitly trying to achieve the abs(inclination) instead of the target. E.g. if target inc. was -20°, the circularization burn tries to achieve 20°, resulting in a 40° inclination burn.
The bug was fixed by removing the
Math.Abs()from theOrbitalManeuverCalculator.DeltaVToChangeInclinationinput.