Skip to content

MCR-3642 Do not require fixed classname properties for implicit classes in collections#2858

Merged
kkrebs merged 1 commit intomainfrom
issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections
Mar 26, 2026
Merged

MCR-3642 Do not require fixed classname properties for implicit classes in collections#2858
kkrebs merged 1 commit intomainfrom
issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections

Conversation

@toKrause
Copy link
Copy Markdown
Contributor

@toKrause toKrause commented Mar 13, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch from 03974c5 to e025e11 Compare March 14, 2026 14:58
@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch from e025e11 to 75afc26 Compare March 16, 2026 19:04
@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch from 75afc26 to c07d0ba Compare March 17, 2026 17:50
@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch from c07d0ba to d9f7cd8 Compare March 19, 2026 15:39
@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch 4 times, most recently from 0363b21 to 1310fbb Compare March 24, 2026 13:46
@toKrause toKrause requested a review from sebhofmann March 24, 2026 13:50
@toKrause toKrause changed the title MCR-3642 Do not require required instances for implicit classes in collections MCR-3642 Do not require explicit classname properties for implicit classes in collections Mar 25, 2026
@toKrause toKrause changed the title MCR-3642 Do not require explicit classname properties for implicit classes in collections MCR-3642 Do not require fixed classname properties for implicit classes in collections Mar 25, 2026
@toKrause toKrause force-pushed the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch from 1310fbb to 2bbe8ec Compare March 25, 2026 13:21
@toKrause
Copy link
Copy Markdown
Contributor Author

rebased to current version of main

@kkrebs kkrebs merged commit 7a578ab into main Mar 26, 2026
3 checks passed
@kkrebs kkrebs deleted the issues/MCR-3642_Do-not-require-required-instances-for-implicit-classes-in-collections branch March 26, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants