Add error handling in stac creation and ingestion #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-lesinger
changed the title
1 task
ividito
approved these changes
Dec 11, 2025
Contributor
ividito
left a comment
ividito
left a comment
There was a problem hiding this comment.
One nit (the same pattern is also repeated a couple other times in the PR), but overall this is good and should help us with debugging 👍
|
|
||
| # Extract filename/item_id from the event for error reporting | ||
| item_id = event.get("id", "unknown") | ||
| filename = "unknown" |
Contributor
There was a problem hiding this comment.
Can this be None to allow us to differentiate between the two types of "unknowns"
Member
Author
There was a problem hiding this comment.
@ividito just for clarification, are you suggesting that we make either item_id or filename None?
smohiudd
reviewed
Dec 19, 2025
| except Exception as ex: | ||
| out_err: StacItemOutput = {"stac_item": {"error": f"{ex}", "event": event}} | ||
| # Extract filename from first asset for better error reporting | ||
| filename = "unknown" |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = "unknown" |
smohiudd
reviewed
Dec 19, 2025
| if event.get("assets"): | ||
| first_asset = next(iter(event["assets"].values()), {}) | ||
| href = first_asset.get("href", "") | ||
| filename = href.split("/")[-1] if href else "unknown" |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = href.split("/")[-1] if href else "unknown" | |
| filename = href.split("/")[-1] if href else None |
smohiudd
reviewed
Dec 19, 2025
| href = first_asset.get("href", "") | ||
| filename = href.split("/")[-1] if href else "unknown" | ||
|
|
||
| item_id = event.get("item_id", "unknown") |
Contributor
There was a problem hiding this comment.
Suggested change
| item_id = event.get("item_id", "unknown") | |
| item_id = event.get("item_id") |
smohiudd
reviewed
Dec 19, 2025
| error_breakdown[error_msg] = error_breakdown.get(error_msg, 0) + 1 | ||
|
|
||
| # Extract filename | ||
| filename = failure.get('filename', 'unknown') |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = failure.get('filename', 'unknown') | |
| filename = failure.get('filename') |
smohiudd
reviewed
Dec 19, 2025
|
|
||
| # Extract filename | ||
| filename = failure.get('filename', 'unknown') | ||
| if filename == 'unknown' and 'event' in failure: |
Contributor
There was a problem hiding this comment.
Suggested change
| if filename == 'unknown' and 'event' in failure: | |
| if filename is not None and 'event' in failure: |
smohiudd
reviewed
Dec 19, 2025
| if assets: | ||
| first_asset = next(iter(assets.values()), {}) | ||
| href = first_asset.get('href', '') | ||
| filename = href.split("/")[-1] if href else 'unknown' |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = href.split("/")[-1] if href else 'unknown' | |
| filename = href.split("/")[-1] if href else None |
smohiudd
reviewed
Dec 19, 2025
| ) | ||
|
|
||
| # Extract filename/item_id from the event for error reporting | ||
| item_id = event.get("id", "unknown") |
Contributor
There was a problem hiding this comment.
Suggested change
| item_id = event.get("id", "unknown") | |
| item_id = event.get("id") |
smohiudd
reviewed
Dec 19, 2025
|
|
||
| # Extract filename/item_id from the event for error reporting | ||
| item_id = event.get("id", "unknown") | ||
| filename = "unknown" |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = "unknown" | |
| filename = None |
smohiudd
reviewed
Dec 19, 2025
| if assets: | ||
| first_asset = next(iter(assets.values()), {}) | ||
| href = first_asset.get("href", "") | ||
| filename = href.split("/")[-1] if href else "unknown" |
Contributor
There was a problem hiding this comment.
Suggested change
| filename = href.split("/")[-1] if href else "unknown" | |
| filename = href.split("/")[-1] if href else None |
smohiudd
requested changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Generally would recommend not using "unknown" and instead just defaulting to None. Python dict get method automatically returns None when the key doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses #325 partially. These proposed changes will add additional information regarding what the actual errors are and which files and ID's are associated with the file error. My current issue was only in the
submit_stac.pywhich had the errors I've listed below.These changes improve the error reporting within Airflow and if the process is killed then the debugging process is made simpler. I've also incorporated the same logging that was completed in #380 for
handler.pywhich also has logging in case the stac creation process has error.Changes
Add additional logging.warnings into
handler.pywhich prints filename that caused the issue.Add logging.error in
submit_stac.pywhich prints the ID and filename that caused the issue.These log directly in Airflow.
See example below for the pre-logging error statement.
See below for the new log errors statement. These are more interpretable.
PR Checklist
terraform validateandterraform plan