Skip to content

Fix: synphot keyword argument deprecation#447

Open
mkelley wants to merge 3 commits into
NASA-Planetary-Science:mainfrom
mkelley:synphot-kwarg-2026.05
Open

Fix: synphot keyword argument deprecation#447
mkelley wants to merge 3 commits into
NASA-Planetary-Science:mainfrom
mkelley:synphot-kwarg-2026.05

Conversation

@mkelley
Copy link
Copy Markdown
Member

@mkelley mkelley commented May 6, 2026

  • Only use flux_unit and wave_unit with synphot's read_*_spec when requested.
  • Respect the cache parameter on SpectralSource.from_file

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@mkelley mkelley force-pushed the synphot-kwarg-2026.05 branch from fbcd5bd to 6515bd2 Compare May 6, 2026 13:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.83%. Comparing base (59a8a49) to head (6515bd2).

Files with missing lines Patch % Lines
sbpy/spectroscopy/sources.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   81.81%   81.83%   +0.01%     
==========================================
  Files          53       53              
  Lines        4267     4271       +4     
==========================================
+ Hits         3491     3495       +4     
  Misses        776      776              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley mkelley requested a review from hhsieh00 May 6, 2026 13:35
@mkelley
Copy link
Copy Markdown
Member Author

mkelley commented May 6, 2026

Ready for review. That uncovered line is covered by the remote tests. Maybe we should enable them on PRs again. (although a few of them are currently failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant