Skip to content

Fix: synphot keyword argument deprecation #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkelley wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: synphot keyword argument deprecation #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e691d7b
Only use wave_unit or flux_unit when requested.
mkelley May 6, 2026
4bd9aae
Respect cache parameter
mkelley May 6, 2026
6515bd2
Fix change log entry
mkelley May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@ sbpy.photometry
- Added Rubin Observatory's LSSTCam filter set to `bandpass()`. [#431]


Bug Fixes
---------

sbpy.spectroscopy
^^^^^^^^^^^^^^^^^

- Avoid deprecation warning on flux_unit and wave_unit keyword arguments in
`sbpy.spectroscopy.sources.SpectralSource.from_file` when using synphot's
read_fits_spec. [#447]


v0.6.0 (2025-12-02)
===================

Expand Down
11 changes: 9 additions & 2 deletions sbpy/spectroscopy/sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,18 @@ def from_file(cls, filename, wave_unit=None, flux_unit=None,

# URL cache because synphot.SourceSpectrum.from_file does not
if _is_url(filename):
fn = download_file(filename, cache=True)
fn = download_file(filename, cache=cache)
else:
fn = filename

spec = read_spec(fn, wave_unit=wave_unit, flux_unit=flux_unit)
# flux_unit and wave_unit were deprecated for FITS files in synphot 1.4;
# only use them if requested
read_kwargs = {}
if wave_unit is not None:
read_kwargs["wave_unit"] = wave_unit
read_kwargs["flux_unit"] = flux_unit

spec = read_spec(fn, **read_kwargs)
i = np.isfinite(spec[1] * spec[2])
source = synphot.SourceSpectrum(
synphot.Empirical1D, points=spec[1][i], lookup_table=spec[2][i],
Expand Down
Loading