change comp_excln parameter to -1 (rank-ordered, deterministic sorting) #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemieux
added
inputs: parameter file
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
rosiealice
approved these changes
Mar 24, 2025
Contributor
rosiealice
left a comment
rosiealice
left a comment
There was a problem hiding this comment.
I think this is a good idea, as we noted, most of our implementations at the moment do not use the competition feature, leading to large duplication of cohorts betweem canopy layers, so this will likely provide non-trivial efficiencies....
github-project-automation
bot
moved this from Under Review
to Final Testing
in FATES Pull Request Planning and Status
Contributor
Contributor
Author
4 tasks
glemieux
added a commit
to ckoven/fates
that referenced
this pull request
May 8, 2025
this commit doesn't include the base_file refenced in the patch as that will become available via NGEET#1358 when these are merged together
glemieux
added a commit
to ckoven/fates
that referenced
this pull request
May 8, 2025
The workflow for merging these should run NGEET#1358 prior to this patch so this patch should use the default to make sure to include NGEET#1358 changes
This was referenced May 8, 2025
glemieux
moved this from Final Testing
to Hold
in FATES Pull Request Planning and Status
Contributor
|
See #1406 (comment) for discussion of test results. This PR will be automerged when #1406 will be integrated into |
github-project-automation
bot
moved this from Hold
to Ready to Integrate
in FATES Pull Request Planning and Status
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 10, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 23, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default value of the
comp_exclnparameter to -1. This leads to the use of the rank-ordered sorting scheme, rather than the current-default probabilistic scheme. The main reason for doing this is that it results in fewer cohorts and therefore makes the model faster, which may be particularly important when increasing the number of canopy layers in #1315. It also has the effect of tending to slightly favor early-successional PFTs, as shown in fig. 13 of Koven et al, 2020, though that is not something that will show up in the kind of global nocomp and SP-mode simulations that this parameter file is currently mainly being aimed at.Description:
Collaborators:
Expectation of Answer Changes:
This will change answers in all cases other than SP.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: