API 40 parameter file merge

[glemieux]

Description:

This pull request merges together #1358 and #1359, which are exclusively parameter file updates. This will also merge in #1355 which includes both parameter file updates and code changes associated with the parameter file update. #1355 has been tested seperately and found to be B4B.

Merging of this pull request is intended to be coordinated with ESCOMP/CTSM#3087.

Collaborators:

@ckoven @mpaiao

Expectation of Answer Changes:

Yes, the parameter value updates in #1358 and #1359 will result in answer changes to non-SP mode runs and logging runs specifically.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

• The in-code documentation has been updated with descriptive comments
• The documentation has been assessed to determine if updates are necessary

Integrator

• FATES PASS/FAIL regression tests were run
• Evaluation of test results for answer changes was performed and results provided

Documentation

• Technical Note update:
• User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

[glemieux]

Regression testing both #1358 and #1359 against fates-sci.1.83.1_api.39.0.0-ctsm5.3.042 is complete on derecho. As expected, the satellite phenology tests show no differences, although there is a FIELDLIST diff as FATES_ZSTAR_AP is now active due to this logic in the history interface:

fates/main/FatesHistoryInterfaceMod.F90

Lines 7180 to 7188 in fe782ba

	if ( ED_val_comp_excln .lt. 0._r8 ) then ! only valid when "strict ppa" enabled
	tempstring = 'active'
	else
	tempstring = 'inactive'
	endif
	call this%set_history_var(vname='FATES_ZSTAR_AP', units='m', &
	long='product of zstar and patch area by age bin (divide by FATES_PATCHAREA_AP to get mean zstar)', &
	use_default=trim(tempstring), avgflag='A', vtype=site_age_r8, &

This also applies to the FatesColdAllVars test as well as that is the only other fates test that does not empty the tapes like the satellite phenology tests.

Aside from tests that engage logging or no competition, all short term tests are b4b. Per discussion with @ckoven this is expected given the changes. I.e. the logging parameter update should create a more immediate impact, while the non-logging tests should see changes that take a bit of time to propagate given the coldstart.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1358-1359-fates-042

[glemieux]

This PR is on hold until #1355 has been merged in and closer to when ESCOMP/CTSM#3087 is ready to go.

[glemieux]

PR #1355 remote tracking branch has been merged into this branch. I've updated the patch parameter xml files as necessary and tested them via running UpdateParamAPI.py for each of the patch files in PR number order (i.e. 1355 -> 1358 -> 1358). This is ready for ESCOMP/CTSM#3087.

[glemieux]

Final regression testing underway on derecho and izumi.

[glemieux]

Regression testing is complete. Results match previous test results against fates-sci.1.84.0_api.40.0.0-ctsm5.3.042-pr1358-1359.

derecho: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1406-pr3087-fates-final
izumi: /scratch/cluster/glemieux/ctsm-tests/tests_0519-235315iz