fix calculation of the distance between model grid and inventory sites #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s by accounting for potential coords format mismatch
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
rgknox
reviewed
Oct 6, 2025
main/FatesInventoryInitMod.F90
Outdated
| invsite = & | ||
| minloc( (sites(s)%lat-inv_lat_list(:))**2.0_r8 + & | ||
| (sites(s)%lon-inv_lon_list(:))**2.0_r8 , dim=1) | ||
| delta_lon_list = abs(modulo((sites(s)%lon - inv_lon_list(:)) + & |
Contributor
There was a problem hiding this comment.
Tempted to create a little unit test for this...
Contributor
Author
There was a problem hiding this comment.
@rgknox Go ahead! it's always good to have one.
using great circle for calculating site/inventory adjacency, unit tests
rgknox
approved these changes
Oct 10, 2025
rgknox
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
glemieux
approved these changes
Nov 10, 2025
Contributor
glemieux
left a comment
glemieux
left a comment
There was a problem hiding this comment.
Looks good! Good call using and modding the Great Circle utility.
glemieux
moved this from Under Review
to Final Testing
in FATES Pull Request Planning and Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this PR fix #1457
Collaborators:
@glemieux @rgknox
Expectation of Answer Changes:
Should not expect any change in model results but to fix potential model failure if coords of inventory sites are on different scales from those of model grids
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: