Bound treelai if leafc_per_unitarea is tiny. #1506
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1487
Bound treelai to non-negative due to
log(exp(-X))+Xhaving precision ~1e-16 for 64-bit floats.This should prevent endrun here:
fates/biogeophys/FatesPlantRespPhotosynthMod.F90
Lines 1091 to 1097 in 75a465c
Collaborators:
@JessicaNeedham @rosiealice @glemieux
Expectation of Answer Changes:
Should be bfb, mb roundoff.
Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
No update needed.
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: