Skip to content

Bound treelai if leafc_per_unitarea is tiny. #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bound treelai if leafc_per_unitarea is tiny. #1506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions biogeochem/FatesAllometryMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,8 @@ real(r8) function tree_lai( leaf_c, pft, c_area, nplant, cl, canopy_lai, vcmax25
tree_lai = (log(exp(-1.0_r8 * kn * canopy_lai_above) - &
kn * slat * leafc_per_unitarea) + &
(kn * canopy_lai_above)) / (-1.0_r8 * kn)

! precision errors in the above when leafc_per_unit_area is tiny can make treelai negative
tree_lai = max(0.0_r8,tree_lai)
! If leafc_per_unitarea becomes too large, tree_lai becomes an imaginary number
! (because the tree_lai equation requires us to take the natural log of something >0)
! Thus, we include the following error message in case leafc_per_unitarea becomes too large.
Expand All @@ -774,7 +775,8 @@ real(r8) function tree_lai( leaf_c, pft, c_area, nplant, cl, canopy_lai, vcmax25
kn * slat * leafc_slamax) + &
(kn * canopy_lai_above)) / (-1.0_r8 * kn)) + &
(leafc_per_unitarea - leafc_slamax) * sla_max

! precision errors in the above when leafc_per_unit_area is tiny can make treelai negative
tree_lai = max(0.0_r8,tree_lai)
! if leafc_slamax becomes too large, tree_lai_exp becomes an imaginary number
! (because the tree_lai equation requires us to take the natural log of something >0)
! Thus, we include the following error message in case leafc_slamax becomes too large.
Expand Down