Hindcast from nwm-rte - #43
Merged
Merged
Conversation
…o config file (original behavior) or instance of InputConfig (new behavior), in anticipation of being called by nwm-rte.
…t realizations for the caller to execute.
21 tasks
jswade-rtx
reviewed
Jul 21, 2026
| @@ -135,7 +133,7 @@ from nwm_fcst_mgr.forecast import run_hindcast | |||
|
|
|||
| run_hindcast( | |||
There was a problem hiding this comment.
Can you update the README for hindcasting to include the new yield_realization arg?
jswade-rtx
reviewed
Jul 21, 2026
| num_iterations, | ||
| cold_start_state=None, | ||
| yield_realizations: bool = False, | ||
| ) -> None | Generator[int, None, None]: |
There was a problem hiding this comment.
Should this hint be Generator[RealizationBuilder, None, None], since we yield rb? Where is the int coming from?
jswade-rtx
approved these changes
Jul 22, 2026
jswade-rtx
left a comment
jswade-rtx
left a comment
There was a problem hiding this comment.
Tested state load for hindcasting and parallel processing for hindcasting. Looks good to me.
Author
|
Restored branch temporarily in order to mirror these changes to the |
mxkpp
added a commit
that referenced
this pull request
Jul 23, 2026
Mirror PR #43 for ParallelWorks Branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes function
run_hindcastby adding a new boolean parameteryield_realizations. When True, this function acts as a Generator of (built) RealizationBuilder instances, and in that mode does not actually run ngen on each realization built. This is leveraged by the following nwm-rte PR:Changes param
input_path(a string path to a .config file) to have type flexibility -- if provided as a string it will behave as it had before, but if provided as aInputConfiginstance it will be used directly, bypassing the need for a .config file.Exposes a new boolean param
do_override_log_file_prefixon methodpreprocess, allowing callers to change the OS env var affecting the log file prefix without needing to interact with the OS env var directly. nwm-rte's hindcast workflow needs this since it runs multiple realizations within onedocker runcall.