OP dataset generator (for use in Kaggle Dataset publishing) - #491
Merged
Conversation
comcon1
marked this pull request as ready for review
April 25, 2026 14:19
comcon1
force-pushed
the
datasets-geenerator
branch
from
May 8, 2026 16:11
37cd713 to
e93a8d3
Compare
batukav
reviewed
May 10, 2026
Collaborator
There was a problem hiding this comment.
Might be worth fixing before merge is the dataframe preallocation in _prepare_df_common, which can leave NaN/-1 rows in the output when not every opdict entry has a SMILEIDX mapping. Beyond that there's a fair amount of duplication between the two store_to_hdf5 implementations that the abstract base could absorb. Minor cleanups noted inline.
batukav
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is a shorter version of the all-dataset version #476. It's much shorter for review.
This PR: NMRLipids/BilayerData#388 already uses this branch.
It has additional dependencies:
tablesandunidecode, and it has very simple usage:It will generate one or another dataset in HDF5 format.
📚 Documentation preview 📚: https://databank--491.org.readthedocs.build/