Add atomic point quality dataset generator - #495
Merged
Conversation
batukav
reviewed
May 10, 2026
Collaborator
There was a problem hiding this comment.
Left a few inline comments. The most important one is the hasattr typo in add_experiment_data that resets _exp_opdicts on every call — as written, lipids with multiple paired experiments will only have the last one survive into the average. The rest are smaller cleanups.
2 tasks
comcon1
marked this pull request as draft
May 14, 2026 13:33
comcon1
marked this pull request as ready for review
May 19, 2026 07:51
batukav
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script generates the point quality dataset of the following schema:
For a single carbon atom, if proton's OP value cannot be different (there is only one proton or 3 protons), then H ID is only "1" and only single value is used.
For CH2 groups, protons can be different, we assign 1 to be proton with smaller absolute OP and 2 with larger.
This clears the problem of the uncertainty of chirality that we have for some atoms.
We do not trust the sign of the OP value in any experiments. Signs are always inherited from the simulation.
All values from all experiments are averaged using only
c,hpair as a key.📚 Documentation preview 📚: https://databank--495.org.readthedocs.build/