Skip to content

Add atomic point quality dataset generator - #495

Merged
comcon1 merged 6 commits into
mainfrom
add-op-q-dataset
May 19, 2026
Merged

Add atomic point quality dataset generator#495
comcon1 merged 6 commits into
mainfrom
add-op-q-dataset

Conversation

@comcon1

@comcon1 comcon1 commented May 10, 2026

Copy link
Copy Markdown
Member

This script generates the point quality dataset of the following schema:

c h val_s err_s val_e err_e
Carbon SMILE ID H ID OP value (simulatioon) err OP value (experiment), with the sign from the simulation err

For a single carbon atom, if proton's OP value cannot be different (there is only one proton or 3 protons), then H ID is only "1" and only single value is used.

For CH2 groups, protons can be different, we assign 1 to be proton with smaller absolute OP and 2 with larger.
This clears the problem of the uncertainty of chirality that we have for some atoms.

We do not trust the sign of the OP value in any experiments. Signs are always inherited from the simulation.

All values from all experiments are averaged using only c,h pair as a key.


📚 Documentation preview 📚: https://databank--495.org.readthedocs.build/

@comcon1 comcon1 self-assigned this May 10, 2026
@comcon1 comcon1 added the enhancement New feature or request label May 10, 2026

@batukav batukav left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few inline comments. The most important one is the hasattr typo in add_experiment_data that resets _exp_opdicts on every call — as written, lipids with multiple paired experiments will only have the last one survive into the average. The rest are smaller cleanups.

Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
Comment thread developer/gen-atomicq-dataset.py Outdated
@comcon1
comcon1 marked this pull request as draft May 14, 2026 13:33
@comcon1
comcon1 force-pushed the add-op-q-dataset branch from e1d963e to 4633064 Compare May 19, 2026 07:40
@comcon1
comcon1 marked this pull request as ready for review May 19, 2026 07:51
@comcon1
comcon1 requested a review from batukav May 19, 2026 07:51
@comcon1
comcon1 merged commit fca590a into main May 19, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants