Skip to content

Update ccpp-physics to include sfcsub cleanup#1062

Closed
ClaraDraper-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
ClaraDraper-NOAA:update-ccpp-physics-sfcsub-cleanup
Closed

Update ccpp-physics to include sfcsub cleanup#1062
ClaraDraper-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
ClaraDraper-NOAA:update-ccpp-physics-sfcsub-cleanup

Conversation

@ClaraDraper-NOAA
Copy link
Copy Markdown
Contributor

Description

ccpp-physics hash update for PR ufs-community/ccpp-physics#343

Do PRs in upstream repositories need to be merged first?

ufs-community/ccpp-physics#343

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get reviews on this PR so that we can process WM parent PR 3076?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

We usually require developers to also update .gitmodules to point to fork/branch where the changes are made. Then, after the corresponding submodule is merged (ccpp-physics in this case), you will revert the changes in the .gitmodule to point to develop branch and update submodule commit hash.

@ClaraDraper-NOAA
Copy link
Copy Markdown
Contributor Author

ClaraDraper-NOAA commented Feb 5, 2026 via email

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@ClaraDraper-NOAA It is not, but sometimes a few tests will time out, which is not usually cause for concern. What does the log say?

@ClaraDraper-NOAA
Copy link
Copy Markdown
Contributor Author

hafs_regional_storm_following_1nest_atm_ocn_wav_mom6

baseline dir = /scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/develop-20260126/hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel
working dir = /scratch4/BMC/gsienkf/Clara.Draper/ufs_testing//RT_RUNDIRS/Clara.Draper/FV3_RT/rt_3431193/hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel
Checking test hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel results ....
Comparing atmf003.nc .....USING NCCMP......OK
Comparing sfcf003.nc .....USING NCCMP......OK
Comparing atm.nest02.f003.nc .....USING NCCMP......OK
Comparing sfc.nest02.f003.nc .....USING NCCMP......OK
Comparing RESTART/20200825.150000.MOM.res.nc .....USING NCCMP......OK
Comparing RESTART/20200825.150000.MOM.res_1.nc .....USING NCCMP......OK
Comparing 20200825.150000.out_grd.ww3 .....USING CMP......OK
Comparing 20200825.150000.out_pnt.ww3.nc .....USING NCCMP......OK

0: The total amount of wall time = 1062.311798
0: The maximum resident set size (KB) = 1086716

Test hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel PASS

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA I believe Clara has made the requested changes. Could you take a look?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA I believe Clara has made the requested changes. Could you take a look?

Looks good. Thanks @ClaraDraper-NOAA

@DusanJovic-NOAA DusanJovic-NOAA changed the title Update ccpp-physics to include sfcsub cleanup (PR #343) Update ccpp-physics to include sfcsub cleanup Feb 6, 2026
@rhaesung
Copy link
Copy Markdown
Contributor

@ClaraDraper-NOAA ccpp-physics PR has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@b73b97b) and revert the .gitmodules file in preparation for the merge.

@grantfirl
Copy link
Copy Markdown
Collaborator

@rhaesung @DusanJovic-NOAA This was combined into #1060 and merged already, right? If so, this can be closed.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Merged via #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants