Update ccpp-physics to include sfcsub cleanup#1062
Update ccpp-physics to include sfcsub cleanup#1062ClaraDraper-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
Conversation
|
Could we get reviews on this PR so that we can process WM parent PR 3076? |
|
We usually require developers to also update .gitmodules to point to fork/branch where the changes are made. Then, after the corresponding submodule is merged (ccpp-physics in this case), you will revert the changes in the .gitmodule to point to develop branch and update submodule commit hash. |
|
Gillian,
The test_changes.list has:
hafs_regional_storm_following_1nest_atm_ocn_wav_mom6 intel
Is this expected?
…On Thu, Feb 5, 2026 at 9:53 AM Gillian Petro ***@***.***> wrote:
*gspetro-NOAA* left a comment (NOAA-EMC/ufsatm#1062)
<#1062 (comment)>
Could we get reviews on this PR so that we can process WM parent PR 3076?
—
Reply to this email directly, view it on GitHub
<#1062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH7BYD5DFR4K3WMKU3KFGK34KNKPXAVCNFSM6AAAAACTWDE2JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNJUGE2DKMRWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
--------------------------------------------------------------------
Clara Draper
Physical Scientist
NOAA Environmental Modeling Center
College Park, MD
--------------------------------------------------------------------
|
|
@ClaraDraper-NOAA It is not, but sometimes a few tests will time out, which is not usually cause for concern. What does the log say? |
baseline dir = /scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/develop-20260126/hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel 0: The total amount of wall time = 1062.311798 Test hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel PASS |
Updated .gitmodules.
|
@DusanJovic-NOAA I believe Clara has made the requested changes. Could you take a look? |
Looks good. Thanks @ClaraDraper-NOAA |
|
@ClaraDraper-NOAA ccpp-physics PR has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@b73b97b) and revert the .gitmodules file in preparation for the merge. |
|
@rhaesung @DusanJovic-NOAA This was combined into #1060 and merged already, right? If so, this can be closed. |
|
Merged via #1060 |
Description
ccpp-physics hash update for PR ufs-community/ccpp-physics#343
Do PRs in upstream repositories need to be merged first?
ufs-community/ccpp-physics#343