Skip to content

Add cpld_control_c1152 operational config tests for weekly RTs#2749

Merged
gspetro-NOAA merged 53 commits intoufs-community:developfrom
dpsarmie:fix/update_c768_case
Feb 13, 2026
Merged

Add cpld_control_c1152 operational config tests for weekly RTs#2749
gspetro-NOAA merged 53 commits intoufs-community:developfrom
dpsarmie:fix/update_c768_case

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented May 22, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR creates the C1152 test for weekly regression testing. Work on the c1152 and testing of the configurations were done by Denise and the tests will run on WCOSS2 and Ursa. The updates will allow for weekly tests of the GFS v17 configuration to be made and tracked on both Ursa and WCOSS2. Other machines can be included in the future as needed.
There are also new initial condition files that will need to be added by EPIC to the RDHPCS machines.

Commit Message:

* UFSWM - Create c1152 regression test suite

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR. The PR only fixes a regression test that was already present.

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

Input data Changes:

  • New input data.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Ursa
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie self-assigned this May 22, 2025
@dpsarmie dpsarmie added Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. New Baselines New baselines will be added to project. labels May 22, 2025
@ulmononian
Copy link
Copy Markdown
Collaborator

@dpsarmie this is great -- thanks for adding this. does this use v2 surface data, by chance?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@dpsarmie Did your input data get scrubbed? I don't see it in the listed location.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

@dpsarmie Did your input data get scrubbed? I don't see it in the listed location.

Looks like it. I'll get it back up and put it in a non-stmp directory. Thanks for the heads up.

@dpsarmie this is great -- thanks for adding this. does this use v2 surface data, by chance?

@ulmononian Sorry, missed your message but no it does not. I can modify it if the v2 data are more useful.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

@dpsarmie Did your input data get scrubbed? I don't see it in the listed location.

Data are back up on Hera at the same location. I'll keep an eye on it to keep it from getting scrubbed.

@dpsarmie dpsarmie marked this pull request as ready for review June 23, 2025 15:18
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Jul 2, 2025

@dpsarmie rsynced new input files on hera and derecho: /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/FV3_fix_tiled/C768mx025 and /glade/derecho/scratch/epicufsrt/ufs-weather-model/RT/NEMSfv3gfs/input-data-20250507/FV3_fix_tiled/C768mx025

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

dpsarmie commented Jul 2, 2025

@dpsarmie rsynced new input files on hera and derecho: /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/FV3_fix_tiled/C768mx025 and /glade/derecho/scratch/epicufsrt/ufs-weather-model/RT/NEMSfv3gfs/input-data-20250507/FV3_fix_tiled/C768mx025

Thanks @jkbk2004 , I'll go ahead and test it out on Hera and see if @edougherty32 can get it going on Derecho.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

dpsarmie commented Jul 2, 2025

I was able to generate new baselines on Hera.

@dpsarmie dpsarmie changed the title Update control_c768 configs Update control_c768 configs and add cpld_control_c1152 Sep 3, 2025
gspetro-NOAA added a commit to gspetro-NOAA/ufs-weather-model that referenced this pull request Sep 8, 2025
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Hopefully your fix will remedy this as well tho. But I wanted to document here just in case, since the message is slightly different. My run_dir is: /scratch4/NAGAPE/epic/Gillian.Petro/stmp/RT_RUNDIRS/Gillian.Petro/FV3_RT/rt_3383230 and log dir is /scratch3/NAGAPE/epic/Gillian.Petro/ursa/RTs/ufs-wm/2749/tests/logs/log_ursa

Probably unrelated. I added a commit and testing it now. Don't know why this didn't show up earlier but I'll do a deep dive later to answer that.

I was wondering the same thing! But also, you added MOM6_OUTPUT_FH in cpld_control_c1152_v17, but the mpi case was failing, too.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

dpsarmie commented Feb 6, 2026

I was wondering the same thing! But also, you added MOM6_OUTPUT_FH in cpld_control_c1152_v17, but the mpi case was failing, too.

The mpi and restart both source the control file source ${PATHRT}/tests/cpld_control_c1152_v17 so it shouldn't need to be defined across all tests.
I'll clean it up in a future PR once I figure out what went wrong initially. I don't want to hold this PR up too much longer.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

@dpsarmie it looks like the changes resolved the error for the cpld case, but I'm still running into issues during comparison for the control_p8 ORT, missing baselines within the STMP directory, the required files seem to be present within the PTMP directory at /scratch3/NCEPDEV/stmp/Fernando.Andrade-maldonado/ORT-ptmp/Fernando.Andrade-maldonado/FV3_OPNREQ_TEST/opnReqTest_3492704/

testing run out of /scratch3/NAGAPE/epic/Fernando.Andrade-maldonado/reg-test/wm/ursa/2749/orts/control/tests

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

dpsarmie commented Feb 6, 2026

@dpsarmie it looks like the changes resolved the error for the cpld case, but I'm still running into issues during comparison for the control_p8 ORT, missing baselines within the STMP directory, the required files seem to be present within the PTMP directory at /scratch3/NCEPDEV/stmp/Fernando.Andrade-maldonado/ORT-ptmp/Fernando.Andrade-maldonado/FV3_OPNREQ_TEST/opnReqTest_3492704/

testing run out of /scratch3/NAGAPE/epic/Fernando.Andrade-maldonado/reg-test/wm/ursa/2749/orts/control/tests

Ok, I'll take a look again. I'm fine if you all want to move onto the next PR in the meantime.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

The previously failed tests passed on Ursa. The one that previously passed failed due to timeout. I'm rerunning, since there has been a push since that former pass. Things are running on Gaea w/latest hash, but no results yet.

 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Feb 7, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Feb 9, 2026

@dpsarmie FYI 3/4 tests on my Hercules run passed!

PASS -- COMPILE 's2sw_32bit_pdlib_debug_intel' [05:11, 03:58] ( 339 warnings 2757 remarks )
FAILED: RUN DID NOT COMPLETE -- TEST 'cpld_debug_c1152_v17_intel' [, ]( MB)

PASS -- COMPILE 's2sw_32bit_pdlib_intel' [19:12, 17:25] ( 1 warnings 1028 remarks )
PASS -- TEST 'cpld_control_c1152_v17_intel' [41:30, 36:17](4204 MB)
PASS -- TEST 'cpld_restart_c1152_v17_intel' [30:35, 18:34](4241 MB)
PASS -- TEST 'cpld_mpi_c1152_v17_intel' [47:31, 42:29](4740 MB)

err file shows a bunch of forrtl: error (65): floating invalid errors for the debug case.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Adding a note that RTs, ORTs, and weekly RTs tests passed on Ursa after a clean rerun.

Copy link
Copy Markdown
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run a sanity check on Ursa & Hercules -- all RTs pass including all weekly RTs that run on those machines.

@gspetro-NOAA gspetro-NOAA merged commit 31f9d55 into ufs-community:develop Feb 13, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adds Input Data New input data needs to be added (e.g., for new test). No existing input data is changed. New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Loosen the restriction in RTs that Mediator runs on <300 Tasks Update C768 case for weekly RTs