You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.
Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.
Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.
@gspetro-NOAA , probably, I'm not sure if that is used in FV3 anymore. That should be question for https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere maintainers. I see couple of names in log: Vithika Shah, XuLu-NOAA, Bin Liu, Philip.Pegion, Brian Curtis, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contains code changes required to upgrade the WM to spack-stack v2.1.0:
Fixes #409
How Has This Been Tested?
TBD.
Will run WM RT and communicate issues with developers, who may put in their own PRs.
Checklist:
Please check all whether they apply or not
Contributors (optional):
@RatkoVasic-NOAA @rickgrubin-noaa