Skip to content

Upgrade WM to spack-stack 2.1.0#410

Draft
gspetro-NOAA wants to merge 2 commits intoNOAA-GFDL:dev/emcfrom
gspetro-NOAA:feature/ss2.x
Draft

Upgrade WM to spack-stack 2.1.0#410
gspetro-NOAA wants to merge 2 commits intoNOAA-GFDL:dev/emcfrom
gspetro-NOAA:feature/ss2.x

Conversation

@gspetro-NOAA
Copy link
Copy Markdown

@gspetro-NOAA gspetro-NOAA commented Apr 2, 2026

Description
Contains code changes required to upgrade the WM to spack-stack v2.1.0:

Fixes #409

How Has This Been Tested?

TBD.
Will run WM RT and communicate issues with developers, who may put in their own PRs.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Contributors (optional):

@RatkoVasic-NOAA @rickgrubin-noaa

@JosephMouallem
Copy link
Copy Markdown
Contributor

Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.

@gspetro-NOAA
Copy link
Copy Markdown
Author

Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.

@RatkoVasic-NOAA Do you know the answer to this?

@RatkoVasic-NOAA
Copy link
Copy Markdown

Could ncep2fms subroutines be removed all together? It looks like their main purpose was to compute sst_ncep which is now removed. So now they are being called to only compute some local coefficients that are not used, unless I am missing something.

@RatkoVasic-NOAA Do you know the answer to this?

@gspetro-NOAA , probably, I'm not sure if that is used in FV3 anymore. That should be question for https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere maintainers. I see couple of names in log: Vithika Shah, XuLu-NOAA, Bin Liu, Philip.Pegion, Brian Curtis, ...

@lharris4
Copy link
Copy Markdown
Contributor

lharris4 commented Apr 7, 2026

I don't believe we are using external_sst() anymore at GFDL as we have replaced this with data_override calls in our models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants