Skip to content

[Config | Dace] Remove DaCeConfig from restart#184

Merged
fmalatino merged 3 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:fix/dace_config_initialization
Apr 14, 2026
Merged

[Config | Dace] Remove DaCeConfig from restart#184
fmalatino merged 3 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:fix/dace_config_initialization

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

The current status of the configuration for orchestration is very fragile. This PR comes after a bad change on the default fixed here. We will now force the usage of FV3_DACEMODE by reseting the DaceConfig when we have the Communicator ready.

Details:

  • Remove DaceConfig via dict (unusuable)
  • Use the deffered initialization to push a DaceConfig which is controlled by FV3_DACEMODE

How Has This Been Tested?

Ran orchestrated c12 from config

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Use the defered initialization to push a DaceConfig which is controlled by FV3_DACEMODE
Copy link
Copy Markdown
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending unit tests pass

@FlorianDeconinck FlorianDeconinck changed the title [Config | Dace] Force usage of FV3_DACEMODE for orchestration [Config | Dace] Remove DaCeConfig from restart as this will trigger bad default behavior Apr 10, 2026
@FlorianDeconinck FlorianDeconinck changed the title [Config | Dace] Remove DaCeConfig from restart as this will trigger bad default behavior [Config | Dace] Remove DaCeConfig from restarty Apr 10, 2026
@FlorianDeconinck FlorianDeconinck changed the title [Config | Dace] Remove DaCeConfig from restarty [Config | Dace] Remove DaCeConfig from restart Apr 10, 2026
@FlorianDeconinck
Copy link
Copy Markdown
Collaborator Author

This requires me to unhook the DaCeConfig from the restart read and recreate post-read.

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator Author

@fmalatino : this passes now and should be merge ready

@fmalatino fmalatino added this pull request to the merge queue Apr 14, 2026
Merged via the queue into NOAA-GFDL:develop with commit 30bbd1c Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants