Skip to content

[Config | Dace] Remove DaCeConfig from restart #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmalatino merged 3 commits into from
Apr 14, 2026
Merged

[Config | Dace] Remove DaCeConfig from restart #184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
266d11f
Remove `DaceConfig` via dict (unusuable)
FlorianDeconinck Mar 27, 2026
cf63b70
Lint
FlorianDeconinck Mar 27, 2026
c37c4fb
Pop config form restart write
FlorianDeconinck Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions pace/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,6 @@ def from_dict(cls, kwargs: Dict[str, Any]) -> "DriverConfig":
hooks=analytic_hooks,
)

if (
isinstance(kwargs["stencil_config"], dict)
and "dace_config" in kwargs["stencil_config"].keys()
):
kwargs["stencil_config"]["dace_config"] = DaceConfig.from_dict(
data=kwargs["stencil_config"]["dace_config"]
)
if (
isinstance(kwargs["stencil_config"], dict)
and "compilation_config" in kwargs["stencil_config"].keys()
Expand All @@ -312,10 +305,6 @@ def write_for_restart(
restart_path: str,
):
config_dict = dataclasses.asdict(self)
if self.stencil_config.dace_config:
config_dict["stencil_config"][
"dace_config"
] = self.stencil_config.dace_config.as_dict()
config_dict["stencil_config"][
"compilation_config"
] = self.stencil_config.compilation_config.as_dict()
Expand All @@ -338,6 +327,10 @@ def write_for_restart(
# restart config doesn't have 'case'
if "case" in config_dict["initialization"]["config"].keys():
del config_dict["initialization"]["config"]["case"]
# remove dace config - it will be init from other piece of the config
# during Driver.__init__
config_dict["stencil_config"].pop("dace_config", None)

with open(f"{restart_path}/restart.yaml", "w") as file:
yaml.safe_dump(config_dict, file)

Expand Down Expand Up @@ -592,6 +585,11 @@ def _update_driver_config_with_communicator(
communicator=communicator,
)
self.config.stencil_config.compilation_config = compilation_config
self.config.stencil_config.dace_config = DaceConfig(
communicator=communicator,
backend=self.config.stencil_config.backend,
orchestration=None,
)

@dace_inhibitor
def _callback_diagnostics(self):
Expand Down