Skip to content

Upgrade to ninterp 0.7.0 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade to ninterp 0.7.0 #308

wants to merge 5 commits into from

Conversation

kylecarow
Copy link
Collaborator

Upgrades ninterp to the most recent version, avoiding any panicking function calls.

# Conflicts:
#	rust/routee-compass-powertrain/src/model/prediction/interpolation/interpolation_speed_grade_model.rs
This was referenced Apr 28, 2025
@robfitzgerald
Copy link
Collaborator

excellent, thanks for the updates @kylecarow. i'm wrapping up my day for the CIMS event but hope to give this a quick test via our test notebook to get it rolled in.

Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I've tested out locally and everything seems to be working as expected. Thanks for adding in!

@kylecarow kylecarow changed the title Upgrade to ninterp 0.6.4 Upgrade to ninterp 0.7.0 May 2, 2025
@kylecarow
Copy link
Collaborator Author

@robfitzgerald @nreinicke Is this failure expected?

https://github.com/NREL/routee-compass/actions/runs/14803711937/job/41568112338?pr=308

it doesnt look like it's coming from anything that I touched.

@robfitzgerald
Copy link
Collaborator

@robfitzgerald @nreinicke Is this failure expected?

https://github.com/NREL/routee-compass/actions/runs/14803711937/job/41568112338?pr=308

it doesnt look like it's coming from anything that I touched.

that's something that hit me as well but i thought it made it into the latest PR. i can propose a fix.

@kylecarow
Copy link
Collaborator Author

kylecarow commented May 2, 2025

Gotcha.

BTW the ninterp bump from 0.6 to 0.7 won't affect any actual code in compass, it just tidies up some serde formats - I just figured I would sneak it in while the PR is still open! Won't need an extensive re-review.

@robfitzgerald
Copy link
Collaborator

can you pull in changes from main?

@robfitzgerald
Copy link
Collaborator

ok! @kylecarow i've proposed a fix in #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants