Skip to content

Conversation

@mjprilliman
Copy link
Collaborator

@mjprilliman mjprilliman commented Oct 23, 2025

Pull Request Template

Description

-Update file readers to better handle missing or incomplete data
-Update mhk_costs to run calculations for different model selections, update capex-dependent capital costs accordingly

[ include directions for reviewers if necessary- what or how should they test or review ]
See email for review instructions

Corresponding branches and PRs:

SAM: NREL/SAM#2128
SAM-private: https://github.com/NREL/SAM-private/pull/138
[ which branches of wex, lk, and ssc should be built with this PR ]

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]

Unit Test Impact:

[ new tests written? ]
To do: add test coverage for mhk_costs

[ expected changes in unit tests or speed of tests? ]

[ expected changes in test_results files? ]

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM Fall 2025 Release milestone Oct 23, 2025
@mjprilliman mjprilliman requested a review from sjanzou October 23, 2025 22:34
@mjprilliman mjprilliman self-assigned this Oct 23, 2025
@mjprilliman mjprilliman added the mhk marine hydrokinetic label Oct 23, 2025
@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18772562589

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5674 unchanged lines in 41 files lost coverage.
  • Overall coverage decreased (-1.0%) to 56.608%

Files with Coverage Reduction New Missed Lines %
ssc/tcs/sco2_cycle_components.h 1 99.2%
ssc/shared/lib_util.cpp 3 54.62%
ssc/ssc/cmod_fuelcell.h 4 80.0%
ssc/tcs/sco2_recompression_cycle.h 6 90.06%
ssc/shared/lib_utility_rate.h 7 0.0%
ssc/tcs/csp_solver_tou_block_schedules.cpp 8 77.33%
ssc/ssc/cmod_battwatts.cpp 10 93.23%
ssc/tcs/heat_exchangers.h 10 83.01%
ssc/tcs/numeric_solvers.cpp 10 75.71%
ssc/shared/lib_battery_dispatch_manual.cpp 11 87.14%
Totals Coverage Status
Change from base Build 18721258026: -1.0%
Covered Lines: 66671
Relevant Lines: 117777

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mhk marine hydrokinetic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants