-
Notifications
You must be signed in to change notification settings - Fork 203
ME File handling, cost model UI updates #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library (need to revert)
5 tasks
… me-ui-updates-fy25
5 tasks
sjanzou
approved these changes
Oct 26, 2025
Collaborator
sjanzou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working with case tested and JPD generated and ssc updates and SAM-private endpoint updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Update ME wave resource file pages to be easier to use
-Remove RM2 from tidal library
-Improve weather folder handling system
-Update cost model updates to happen in cmod_mhk_costs.cpp through ssc_exec, rather than in callback equations
-Add Puerto Rico hindcast data from NREL developer network https://developer.nrel.gov/docs/wave/hindcast/gom-and-pr/
[ include directions for reviewers if necessary- what or how should they test or review ]
See email for test instructions
Corresponding branches and PRs:
[ which branches of wex, lk, and ssc should be built with this PR ]
SAM-private: me-ui-updates-fy25 https://github.com/NREL/SAM-private/pull/138
ssc: me-cost-updates-fy25 NREL/ssc#1357
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
Unit Test Impact:
[ expected changes in test_results files? ]
Todo: run test script
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)