Skip to content

Conversation

@mjprilliman
Copy link
Collaborator

@mjprilliman mjprilliman commented Oct 23, 2025

Pull Request Template

Description

-Update ME wave resource file pages to be easier to use
-Remove RM2 from tidal library
-Improve weather folder handling system
-Update cost model updates to happen in cmod_mhk_costs.cpp through ssc_exec, rather than in callback equations
-Add Puerto Rico hindcast data from NREL developer network https://developer.nrel.gov/docs/wave/hindcast/gom-and-pr/

[ include directions for reviewers if necessary- what or how should they test or review ]
See email for test instructions

Corresponding branches and PRs:

[ which branches of wex, lk, and ssc should be built with this PR ]
SAM-private: me-ui-updates-fy25 https://github.com/NREL/SAM-private/pull/138
ssc: me-cost-updates-fy25 NREL/ssc#1357
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]

Unit Test Impact:

[ expected changes in test_results files? ]
Todo: run test script

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM Fall 2025 Release milestone Oct 23, 2025
@mjprilliman mjprilliman requested a review from sjanzou October 23, 2025 22:30
@mjprilliman mjprilliman self-assigned this Oct 23, 2025
@mjprilliman mjprilliman mentioned this pull request Oct 23, 2025
5 tasks
@mjprilliman mjprilliman mentioned this pull request Oct 24, 2025
5 tasks
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with case tested and JPD generated and ssc updates and SAM-private endpoint updates.

@sjanzou sjanzou merged commit dc1e25e into develop Oct 27, 2025
8 checks passed
@sjanzou sjanzou deleted the me-ui-updates-fy25 branch October 27, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants