feat: add score screen by kevinlee-06 · Pull Request #110 · NTUT-NPC/tattoo

kevinlee-06 · 2026-02-26T18:54:25Z

No description provided.

…and functionality - Moved score-related utility functions and constants to score_view_helpers.dart. - Created score_screen_actions.dart for handling score refresh and last updated caching. - Updated ScoreScreen to utilize new helper functions and actions for better readability and maintainability. - Enhanced academic performance provider to streamline data loading and caching logic.

rileychh-dokploy-riley-ntut-npc · 2026-02-26T18:54:30Z

Dokploy Preview Deployment

Name	Status	Preview	Updated (UTC)
API Docs	✅ Done	Preview URL	2026-02-26T19:51:32.191Z

github-actions · 2026-02-26T18:55:04Z

PR Preview Builds

Build Number: 322
Commit: 907cb3e
Message: feat: enhance score screen layout and add pull-to-refresh functionality

Android (Firebase App Distribution)

Install build 322

- add a TODO for the empty onTap of _tableOwnerIndicator - change _tableOwnerIndicator private [skip ci]

…and functionality - Moved score-related utility functions and constants to score_view_helpers.dart. - Created score_screen_actions.dart for handling score refresh and last updated caching. - Updated ScoreScreen to utilize new helper functions and actions for better readability and maintainability. - Enhanced academic performance provider to streamline data loading and caching logic.

…udent-service' into score-screen-and-student-service

kevinlee-06 · 2026-02-26T22:29:10Z

Dao-you · 2026-02-26T22:32:00Z

@kevinlee-06 What will happen if the average and GPA data are not available yet?

Copilot

Pull request overview

Adds a functional “Scores” screen backed by an offline-first data pipeline that fetches/normalizes academic performance + GPA from NTUT services and persists them locally for fast rendering.

Changes:

Extend StudentQueryService to (a) more robustly parse academic performance tables and (b) fetch/parse per-semester cumulative GPA.
Introduce score screen UI + Riverpod provider/actions for cache-first loading, pull-to-refresh, and “last updated” timestamp handling.
Add Drift schema support for persisting historical cumulative GPA per semester and migrate DB to schema v2.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
lib/services/student_query_service.dart	Improves score parsing strategy; adds GPA fetch + HTML parsing; adds session-expiry detection.
lib/screens/main/score/score_view_helpers.dart	Adds formatting + display helpers for the score UI.
lib/screens/main/score/score_screen_actions.dart	Adds refresh + last-updated timestamp persistence helpers.
lib/screens/main/score/score_screen.dart	Implements the score UI with semester tabs, refresh, summary card, and score list.
lib/screens/main/score/score_providers.dart	Implements cache-first StreamProvider that reads from Drift, refreshes via SSO, enriches course names, and persists results.
lib/database/schema.dart	Adds `grandTotalGpa` to `UserSemesterSummaries`.
lib/database/database.g.dart	Regenerated Drift code for schema change.
lib/database/database.dart	Bumps schema version and adds migration to create the new GPA column.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-26T22:35:49Z

lib/screens/main/score/score_view_helpers.dart

+int findPreferredSemesterIndex(
+  List<SemesterScoreDto> semesters,
+  String? selectedSemesterKey,
+) {
+  if (selectedSemesterKey == null) return -1;
+  return semesters.indexWhere((semester) {
+    return semesterKey(semester) == selectedSemesterKey;
+  });
+}
+
+int findDefaultSemesterIndex(List<SemesterScoreDto> semesters) {
+  final index = semesters.indexWhere((semester) => semester.scores.isNotEmpty);
+  return index >= 0 ? index : 0;
+}
+


findPreferredSemesterIndex / findDefaultSemesterIndex are not used anywhere in the codebase (ScoreScreen has its own private implementations). Consider removing these helpers or updating ScoreScreen to reuse them so we don’t keep dead/duplicated logic around.

Suggested change

int findPreferredSemesterIndex(

List<SemesterScoreDto> semesters,

String? selectedSemesterKey,

) {

if (selectedSemesterKey == null) return -1;

return semesters.indexWhere((semester) {

return semesterKey(semester) == selectedSemesterKey;

});

}

int findDefaultSemesterIndex(List<SemesterScoreDto> semesters) {

final index = semesters.indexWhere((semester) => semester.scores.isNotEmpty);

return index >= 0 ? index : 0;

}

Copilot · 2026-02-26T22:35:49Z

lib/services/student_query_service.dart

 import 'package:tattoo/models/score.dart';
 import 'package:tattoo/models/user.dart';
 import 'package:tattoo/utils/http.dart';
+import 'package:tattoo/services/portal_service.dart';


portal_service.dart is imported but only referenced in doc comments, which will still trigger an unused import lint. Consider removing this import, or adjusting the doc comment to avoid requiring the symbol link/import (or add an explicit usage if you really need the dartdoc link).

Suggested change

import 'package:tattoo/services/portal_service.dart';

Copilot · 2026-02-26T22:35:49Z

lib/services/student_query_service.dart

-  /// Returns a list of [GradeRankingDto] ordered from most recent to oldest,
-  /// each containing ranking positions at class, group, and department levels.
+  /// Returns ranking entries including class, group, and department levels.
+  /// Semester information is spans multiple ranking type rows using `rowspan`.


Docstring grammar issue: "Semester information is spans ..." is ungrammatical and should be reworded (e.g., "Semester information spans ..." or "Semester information is spanned across ...").

Suggested change

/// Semester information is spans multiple ranking type rows using `rowspan`.

/// Semester information spans multiple ranking type rows using `rowspan`.

Copilot · 2026-02-26T22:35:49Z

lib/services/student_query_service.dart

+  /// Fetches grand total GPA records by semester.
+  Future<List<GpaDto>> getGPA() async {
+    final response = await _studentQueryDio.get('QryGPA.jsp');
+
+    if (response.data.toString().contains('應用系統已中斷連線')) {
+      throw Exception('SessionExpired');
+    }
+
+    return _parseGpaFromDocument(parse(response.data));
+  }


getGPA and _parseGpaFromDocument introduce new parsing behavior (including dedupe + sorting) but there are no corresponding tests in test/services/student_query_service_test.dart. Since this repo already has integration tests for StudentQueryService, please add coverage for at least: (1) returns non-empty GPA rows, (2) semesters are ordered most-recent-first, and (3) values parse as doubles.

Copilot · 2026-02-26T22:35:50Z

lib/screens/main/score/score_screen.dart

+            _selectedIndex = activeIndex >= semesters.length ? 0 : activeIndex;
+            _selectedSemesterKey = semesterKey(semesters[_selectedIndex]);


State is being mutated during build (_selectedIndex / _selectedSemesterKey). Mutating State fields in build without setState is error-prone and can lead to hard-to-debug UI inconsistencies. Prefer deriving local variables from semesters + controller, and update persistent selection state only from the tab controller listener (or via setState outside of the build phase).

Suggested change

_selectedIndex = activeIndex >= semesters.length ? 0 : activeIndex;

_selectedSemesterKey = semesterKey(semesters[_selectedIndex]);

final newIndex = activeIndex >= semesters.length ? 0 : activeIndex;

final newSelectedSemesterKey = semesterKey(semesters[newIndex]);

if (newIndex != _selectedIndex ||

newSelectedSemesterKey != _selectedSemesterKey) {

WidgetsBinding.instance.addPostFrameCallback((_) {

if (!mounted) return;

setState(() {

_selectedIndex = newIndex;

_selectedSemesterKey = newSelectedSemesterKey;

});

});

}

kevinlee-06 · 2026-02-26T22:39:44Z

@kevinlee-06 What will happen if the average and GPA data are not available yet?

Re: @Dao-you In cases where the GPA data is unavailable, the _formatDouble() function is designed to return -.

kevinlee-06 and others added 17 commits February 26, 2026 21:48

feat: implement score screen with semester filtering

ccdd1c7

feat: enhance score screen with improved data handling and UI updates

68e13d6

feat: add course table owner indicator

e052995

feat: add tools button to course table AppBar

b03a7b3

fix: enable snap on course table AppBar

74792df

feat: add semester tabs to course table

b844419

fix: adjust button color

e29a360

refactor: improve chip tab switcher readability without behavior changes

e4ba251

feat: add GPA in score screen

b4dee13

fix(ios): add SceneDelegate.swift to Xcode project build sources

e55dbd4

feat: add course table owner indicator

6b30ed2

feat: add tools button to course table AppBar

5ed2bfb

fix: enable snap on course table AppBar

72486b8

feat: add semester tabs to course table

f5a0c85

fix: adjust button color

fd7fc1a

refactor: improve chip tab switcher readability without behavior changes

3f47cdc

Dao-you and others added 3 commits February 27, 2026 03:41

fix: some small issue form copilot

5b5383c

- add a TODO for the empty onTap of _tableOwnerIndicator - change _tableOwnerIndicator private [skip ci]

feat: implement semester tab controller and improve score screen layout

282d100

fix: dart format

930e530

rileychh changed the base branch from main to course-table February 26, 2026 20:04

kevinlee-06 added 7 commits February 27, 2026 04:08

feat: implement score screen with semester filtering

a406eef

feat: enhance score screen with improved data handling and UI updates

c19e2b3

feat: add GPA in score screen

908f4e4

feat: implement semester tab controller and improve score screen layout

c6b7261

fix: dart format

b6d96f2

Merge remote-tracking branch 'refs/remotes/origin/score-screen-and-st…

4cf8c11

…udent-service' into score-screen-and-student-service

kevinlee-06 added 4 commits February 27, 2026 04:12

fix:

1eef205

feat: refactor score screen to use TabBarView for semester scores

3ca4540

feat: simplify semester score handling and update UI layout

d964474

feat: enhance score screen layout and add pull-to-refresh functionality

907cb3e

kevinlee-06 requested a review from Copilot February 26, 2026 22:28

Copilot started reviewing on behalf of kevinlee-06 February 26, 2026 22:28 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Dao-you force-pushed the course-table branch from fa0966c to 96e5de1 Compare February 26, 2026 23:51

rileychh changed the title ~~feat: score sceen~~ feat: add score screen Feb 27, 2026

Dao-you force-pushed the course-table branch 3 times, most recently from 342fd3e to 4276526 Compare February 28, 2026 12:57

rileychh marked this pull request as draft February 28, 2026 15:21

Dao-you force-pushed the course-table branch from 65b9f61 to 6892297 Compare February 28, 2026 15:49

Base automatically changed from course-table to main February 28, 2026 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add score screen#110

feat: add score screen#110
kevinlee-06 wants to merge 31 commits intomainfrom
score-screen-and-student-service

kevinlee-06 commented Feb 26, 2026

Uh oh!

rileychh-dokploy-riley-ntut-npc bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

kevinlee-06 commented Feb 26, 2026

Uh oh!

Dao-you commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

kevinlee-06 commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	/// Semester information is spans multiple ranking type rows using `rowspan`.
	/// Semester information spans multiple ranking type rows using `rowspan`.

		_selectedIndex = activeIndex >= semesters.length ? 0 : activeIndex;
		_selectedSemesterKey = semesterKey(semesters[_selectedIndex]);

-            _selectedIndex = activeIndex >= semesters.length ? 0 : activeIndex;
-            _selectedSemesterKey = semesterKey(semesters[_selectedIndex]);
+            final newIndex = activeIndex >= semesters.length ? 0 : activeIndex;
+            final newSelectedSemesterKey = semesterKey(semesters[newIndex]);
+            if (newIndex != _selectedIndex ||
+                newSelectedSemesterKey != _selectedSemesterKey) {
+              WidgetsBinding.instance.addPostFrameCallback((_) {
+                if (!mounted) return;
+                setState(() {
+                  _selectedIndex = newIndex;
+                  _selectedSemesterKey = newSelectedSemesterKey;
+                });
+              });
+            }

Conversation

kevinlee-06 commented Feb 26, 2026

Uh oh!

rileychh-dokploy-riley-ntut-npc bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dokploy Preview Deployment

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Preview Builds

Android (Firebase App Distribution)

Uh oh!

kevinlee-06 commented Feb 26, 2026

Uh oh!

Dao-you commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

kevinlee-06 commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rileychh-dokploy-riley-ntut-npc bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading