test: add dataloader checkpoint integration test for retrieval recipes#1800
Open
oliverholworthy wants to merge 2 commits intomainfrom
Open
test: add dataloader checkpoint integration test for retrieval recipes#1800oliverholworthy wants to merge 2 commits intomainfrom
oliverholworthy wants to merge 2 commits intomainfrom
Conversation
Validates that bi-encoder and cross-encoder StatefulDataLoaders correctly save and restore iteration state across checkpoint boundaries, ensuring resumed training skips already-seen samples. Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com> Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatefulDataLoaders correctly save and restore iteration state across checkpoint boundariestest_megatron_dataset_checkpoint.pybut targets the retrievalbuild_dataloaderpathTest plan
test_bi_encoder_dataloader_checkpoint— passes locally withtorchrun --nproc-per-node=1test_cross_encoder_dataloader_checkpoint— passes locally withtorchrun --nproc-per-node=1Run locally: