Fix retriever SDG dedup plugin circular import#156
Merged
oliverholworthy merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Ensures source edits under vendor/retriever-sdg/ are picked up on the next run without rebuilding the cached wheel. Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error printed in embed receipe sdg stage:
This error didn't prevent the stage from running sucessfully, but is a confusing error to show up in the logs.
retriever_sdg.deduplicationby publishing thedd_retrieval_dedup_pluginbefore importingColumnGeneratorCellByCell, so Data Designer's re-entrant plugin discovery can resolve the plugin while the generator base class import is still in progress.__all__to make the public surface explicit.Test plan
nemotronembedding SDG dedup stage loads without ImportError on plugin discovery