fix(ci): normalize macOS binary dependencies - #3006
Merged
Merged
Conversation
Closes #2997 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 28, 2026 08:11
|
Label |
alangou
approved these changes
Aug 28, 2026
waynesun09
added a commit
to fullsend-ai/fullsend
that referenced
this pull request
Aug 28, 2026
Renovate only tracks .github/scripts/openshell-version.sh. The runner VM
fallbacks in hack/gitlab-runner-vm/{create-vm,setup}.sh and the install
snippet in docs/guides/user/running-agents-locally.md carry the same
version by hand and were left at 0.0.115, so move them together with the
pin as #6696 did.
The docs snippet matters beyond consistency: 0.0.115's Apple Silicon
binaries were linked against a Nix store libiconv and could not start
(NVIDIA/OpenShell#2997), and the guide pointed macOS users at exactly
that build. 0.0.116 ships the upstream fix (NVIDIA/OpenShell#3006), so
pointing the guide at it resolves the macOS install path.
Closes #6707
Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
8 tasks
fullsend-ai-coder Bot
added a commit
to fullsend-ai/fullsend
that referenced
this pull request
Aug 31, 2026
The guide on main already recommends OpenShell 0.0.116, which ships the upstream Apple Silicon fix (NVIDIA/OpenShell#3006). Update the version pin from 0.0.115 to 0.0.116 and remove the now-obsolete macOS Apple Silicon caveat — users following the current guide will never encounter the 0.0.115 dynamic-linking issue. Addresses review feedback on #6710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Apple Silicon release binaries portable outside the Nix build host by replacing the Nix libiconv load command with the macOS system install name. The shared build action now rejects any remaining Nix-store dylib dependency before upload.
Related Issue
Closes #2997
Changes
otool -Lreports a/nix/storedependency.Deviations from Plan
None — implemented as planned.
Testing
git diff --checkpassesmise run pre-commitnot run, per requeste2e/changesChecklist
Documentation updated:
architecture/build.md: documented Darwin dependency normalization and the no-Nix-store invariant.