ci: cover protected runner queue time - #1065
Conversation
Signed-off-by: chaofengw <chaofengw@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe internal CI bridge now supports a 360-minute dispatch timeout and up to 1,400 polling iterations. Tests verify both workflow limits. ChangesInternal CI bridge timing
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR extends the trusted CI bridge wait budget and adds deterministic coverage without changing permissions, payloads, or publication behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description covers the background, exit criteria, implementation, change category, validation results, revisions, remaining gaps, risk, and rollout context. It clearly identifies the end-to-end validation that remains after merge. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) Comment |
Background
The first post-merge live validation on the dedicated external-contributor PR #1056 exposed a real runner-queue timeout. Public bridge run
33080320518correctly correlated private run33080349314by nonce, but itsWait for the exact Internal CI resultstep failed after 56m53s while the selectedfast_foundation_stereoGPU job was still queued with no steps started. The failure was therefore in the bridge waiting budget, not in nonce correlation, artifact generation, or failure-log rendering.Exit Criteria
Implementation
.logpublication, and status update.Change categories
Validation
Commands and Results
python3 -m tools.community_ci source-quality --base github/main: passed; 158 tests passed, changed-file lint/formatting passed, and the complexity gate passed.git diff --check: passed.Hardware, Environment, and Revisions
870bf4087921acaac9c8f4a8edf138fa6093b8b8.7aa0b211e52ad17f6d827d4c33022b36130e7f01.33080320518, private Internal run33080349314, Source PR test(stereo): cover DHWC8 and probe GPU CI logs #1056 headd3b8f6650f110773a6a54c6d37fcf00203bffb80.Not Run / Remaining Gaps
The complete public failure-log handoff could not run because the original bridge exhausted its 55-minute polling window before a protected GPU runner became available. After this change reaches
main, rerun only #1056 and verify the nonce-correlated artifact, printed.log, status target, root CTest failure block, and sensitive-data checks end to end.Notes For Future Readers
The longest Internal model proof currently has a 180-minute job timeout. The 350-minute polling window covers that execution budget plus substantial protected-runner queueing while staying within GitHub's six-hour hosted-job limit. If Internal model timeouts grow beyond 180 minutes, revisit both budgets together.
Risk level
Risk rationale: this changes only how long the trusted bridge waits for an already exact, nonce-correlated private run. Permissions, payload contents, publication checks, and status context are unchanged.